Closed Bug 313927 Opened 18 years ago Closed 18 years ago

win32: Opening a transparent/translucent window with "popup" still shows taskmenu item


(Core :: Widget: Win32, defect)

Windows XP
Not set





(Reporter: benjamin, Assigned: benjamin)



(Keywords: fixed1.8.1)


(2 files)

I am trying to open a tranparent/translucent hidechrome chrome window with the "popup=yes" flag, which should suppress the windows taskbar item, but it's not. This is apparently fallout from bug 264708, which explicitly removes the WS_EX_TOOLWINDOW flag from hidechrome/transparent windows. This should not be necessary.
Attachment #200901 - Flags: superreview?(roc)
Attachment #200901 - Flags: review?(roc)
Dainis, can you tell us why you removed WS_EX_TOOLWINDOW?
Attachment #200901 - Flags: review?(roc) → review?(Dainis_Jonitis)
Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

I think that it was my error when I changed to mask certain bits of existing window style instead of setting new bits without taking into account what style it had before. Benjamin's code should work just fine.

But can you please check it on Windows 2000 or Win9x just to be sure. There were some differences between WinXP and Win2k.
Attachment #200901 - Flags: review?(Dainis_Jonitis) → review+
unpack this ZIP archive and run "xulrunner /path/to/svgclock/application.ini" to test. If there is no windows taskbar item the patch was successful.
Tested the patch on Win2k and it works.
Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

roc gave MOA based on Dainis' review.
Attachment #200901 - Flags: superreview?(roc)
Fixed on trunk.
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

I want transparent popups on branch please drivers.
Attachment #200901 - Flags: approval1.8.1?
Benjamin can you comment on risk and necessity for the branch?  Is this code path used anywhere in FF/TBird.   Have we tested on win98?
It's been on trunk a while and has no known regressions. This code is certainly part of the core graphics layer included in ffox/tbird, but I don't know of anything other than extensions which might exercise it.
Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

a=mconnor on behalf of drivers for 1.8 branch checkin
Attachment #200901 - Flags: approval1.8.1? → approval1.8.1+
Keywords: fixed1.8.1
Oops, I forgot to credit you for the branch check in. Sorry! :-[
You need to log in before you can comment on or make changes to this bug.