313927 - win32: Opening a transparent/translucent window with "popup" still shows taskmenu item

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Benjamin Smedberg]

I am trying to open a tranparent/translucent hidechrome chrome window with the "popup=yes" flag, which should suppress the windows taskbar item, but it's not. This is apparently fallout from bug 264708, which explicitly removes the WS_EX_TOOLWINDOW flag from hidechrome/transparent windows. This should not be necessary.

Comment 1

[Benjamin Smedberg]

Attachment: don't alter WS_EX_TOOLWINDOW

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Dainis, can you tell us why you removed WS_EX_TOOLWINDOW?

Comment 3

[Dainis Jonitis]

Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

I think that it was my error when I changed to mask certain bits of existing window style instead of setting new bits without taking into account what style it had before. Benjamin's code should work just fine.

But can you please check it on Windows 2000 or Win9x just to be sure. There were some differences between WinXP and Win2k.

Comment 4

[Benjamin Smedberg]

Attachment: XULRunner application testcase

unpack this ZIP archive and run "xulrunner /path/to/svgclock/application.ini" to test. If there is no windows taskbar item the patch was successful.

Comment 5

[Frank Wein [:mcsmurf]]

Tested the patch on Win2k and it works.

Comment 6

[Benjamin Smedberg]

Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

roc gave MOA based on Dainis' review.

Comment 7

[Benjamin Smedberg]

Fixed on trunk.

Comment 8

[[e-mail]]

Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

I want transparent popups on branch please drivers.

Comment 9

[Mike Schroepfer]

Benjamin can you comment on risk and necessity for the branch?  Is this code path used anywhere in FF/TBird.   Have we tested on win98?

Comment 10

[Benjamin Smedberg]

It's been on trunk a while and has no known regressions. This code is certainly part of the core graphics layer included in ffox/tbird, but I don't know of anything other than extensions which might exercise it.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 200901 [details] [diff] [review]
don't alter WS_EX_TOOLWINDOW

a=mconnor on behalf of drivers for 1.8 branch checkin

Comment 12

[[e-mail]]

Oops, I forgot to credit you for the branch check in. Sorry! :-[