313929 - E4X: Sequence ]] should be allowed inside CDATA section

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Aiko]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051025 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051025 Firefox/1.6a1

(Followup to bug 312064)

The only thing not allowed inside a CDATA section should be the sequence ]]> but the engine currently generates a syntax error if it encounters the sequence ]] 



Reproducible: Always

Steps to Reproduce:
1. var x = <x><![CDATA[ ]] ]]></x>
Actual Results:  
SyntaxError: invalid XML markup

Expected Results:  
The same result as |var x = <x> ]] </x>|: a valid XML object containing the text " ]] ".

Comment 1

[Brendan Eich [:brendan]]

Personally I am not going to expend energy and reputation arguing for this bug to be fixed for 1.8/fx1.5.  Or even for js1.6, but Bob, if you want to pull the fix onto the mini-branch, I'm not opposed.  How would I flag this bug for that outcome (some kind of tracking bug, IIRC).

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Comment 3

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 4

[Bob Clary [:bc] (inactive)]

Checking in 11.4.1-06.js;
/cvsroot/mozilla/js/tests/e4x/Expressions/11.4.1-06.js,v  <--  11.4.1-06.js
initial revision: 1.1

Comment 5

[Aiko]

(In reply to comment #4)

I'm sorry that I have to whine again, but this syntax error is (was?) generated during the parsing stage, you cannot catch it. Use the XML constructor instead:

actual = XML("<x><![CDATA[ ]] ]]></x>").toString();

Comment 6

[Bob Clary [:bc] (inactive)]

It doesn't affect the failure in unpatched builds or the success in patched builds, but I made the change:

Checking in 11.4.1-06.js;
/cvsroot/mozilla/js/tests/e4x/Expressions/11.4.1-06.js,v  <--  11.4.1-06.js
new revision: 1.2; previous revision: 1.1
done

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 200908 [details] [diff] [review]
fix

Baked since 10/26/05, a safe fix for an E4X bug that does not have a workaround.

/be

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 200908 [details] [diff] [review]
fix

a=dveditz

Comment 9

[Bob Clary [:bc] (inactive)]

fixed on both branches according to bonsai:

2006-01-10 21:02	brendan%mozilla.org 	mozilla/ js/ src/ jsscan.c 	3.81.2.10 	MOZILLA_1_8_BRANCH  	4/1  	Fix for 313929, a=dveditz.

2006-01-10 21:02	brendan%mozilla.org 	mozilla/ js/ src/ jsscan.c 	3.81.2.7.2.3 	MOZILLA_1_8_0_BRANCH  	4/1  	Fix for 313929, a=dveditz.

Comment 10

[Bob Clary [:bc] (inactive)]

v 2006-01-11 1.8.0.1, 1.8.1, trunk windows/linux/mac