User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 When reporting that a value in a table is bad because it is empty, sanity check gives a vague-sounding error message. For example: Bad value found in bugs.bug_id This makes it look like sanitycheck just doesn't want to tell me what the value is. If there were quotes around the bad value, you'd get this much more helpful message: Bad value "" found in bugs.bug_id Reproducible: Always Steps to Reproduce:
Created attachment 200929 [details] [diff] [review] patch to quote bad values in sanitycheck.cgi
Attachment #200929 - Flags: review?
Comment on attachment 200929 [details] [diff] [review] patch to quote bad values in sanitycheck.cgi Good improvement. Works well, r=wurblzap.
Attachment #200929 - Flags: review? → review+
Assignee: administration → mmchenry
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.22
Checking in sanitycheck.cgi; /cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v <-- sanitycheck.cgi new revision: 1.104; previous revision: 1.103 done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Wow, I have no idea why I added the relnote keyword to this bug. Ah, well. This isn't something that needs to be relnote'd, it's just something that admins will notice and appreciate.
You need to log in before you can comment on or make changes to this bug.