31399 - Crash occurs when selecting Cancel from download dialog

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build 2000-03-10-13-M15(LINUX), 2000-03-10-09-M15(WIN), 2000-03-10-13-M15(MAC)
The crash occurs on builds from 3/09/2000 as well.

1. From http://jimbob/trigger2.html, click drop-down button and choose    
f_addsubcomp_bigfile and click Trigger Case button
2. During download, click Cancel button to halt download

RESULT:
Crash.  Seamonkey completely quits.

EXPECTED RESULT:
Download dialog closes.  Seamonkey remains open.  Crash does not occur from 
2000-03-10-13-M15(WIN) on Win 98, but it still crashes on Win NT.

NOTE:
Linux may or may not crash.  Bug 23046 (Cancel button does nothing) blocks this 
from being tested.  Crash does not occur from 2000-03-10-13-M15(WIN) on Win 98, 
but it still crashes on Win NT.


TalkBack Incident ID = 6641713

Stack Trace
nsXPInstallManager::OnStopRequest 
[d:\builds\seamonkey\mozilla\xpinstall\src\nsXPInstallManager.cpp, line 544] 
nsXPInstallManager::OnDataAvailable 
[d:\builds\seamonkey\mozilla\xpinstall\src\nsXPInstallManager.cpp, line 581] 
InterceptStreamListener::OnDataAvailable 
[d:\builds\seamonkey\mozilla\netwerk\cache\mgr\nsCachedNetData.cpp, line 1127] 
nsHTTPServerListener::OnDataAvailable 
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.cp
p, line 353] 
nsOnDataAvailableEvent::HandleEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line 
397] 
nsStreamListenerEvent::HandlePLEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsAsyncStreamListener.cpp, line 
98] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 557] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 520] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 
1013] 
USER32.dll + 0x1820 (0x77e71820)

Comment 1

[Cathleen]

yeah, I saw it with the release build this morning.
I don't have a debug build to do a stack trace.  Anyone else have one?

Comment 2

[Cathleen]

Dan has found a way to prevent crash... reassign to Dan.
Putting this on Beta1 radar.

Comment 3

[Cathleen]

*** Bug 26481 has been marked as a duplicate of this bug. ***

Comment 4

[Cathleen]

adding crash as a keyword

Comment 5

[leger]

Putting on PDT+ radar for beta1.

Comment 6

[Daniel Veditz [:dveditz]]

Fixed on tip and branch

Comment 7

[Jimmy Lee]

Build: 2000-03-15-06-M15-nb1b(WIN), 2000-03-15-05-M15-nb1b(MAC)

Back to normal.

Comment 8

[Cathleen]

Yes!
I must say, it's looking darn good!  :-)