314018 - Error in configure(.in): Sun CXX (CC) compiler defiens __SUNPRO_CC and not __SUNPRO_C

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Peter Müller]

User-Agent:       Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9a1) Gecko/20051026 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9a1) Gecko/20051026 SeaMonkey/1.1a

Sun Studio Compiler (CC) version check is wrong (configure.in, lines 2025-2031):

        CXX_VERSION=`$CXX -V 2>&1 | grep '^CC:' 2>/dev/null | $AWK -F\: '{ print $2 }'`
       AC_MSG_CHECKING([for Forte compiler version >= WS6U2])
       AC_TRY_COMPILE([],
           [#if (__SUNPRO_C < 0x530)
           #error "Denied"
           #endif],
           _BAD_COMPILER=,_BAD_COMPILER=1)

cc(aka CC) defines __SUNPRO_C and CC(aka CXX) defines __SUNPRO_CC

Reproducible: Always

Comment 1

[Elmar Ludwig]

Do you actually get an error there?

See bug 177486 comment 15 which claims that both work.

Comment 2

[Peter Müller]

(In reply to comment #1)
> Do you actually get an error there?
> 
> See bug 177486 comment 15 which claims that both work.
> 

(In reply to comment #1)
> Do you actually get an error there?

Yes:

checking for Forte compiler version >= WS6U2... configure: error: Forte version WS6U2 or higher is required to build. Your compiler version is  Sun C 5.7 Patch 117837-06 2005/10/05 .
*** Fix above errors and then restart with "gmake -f client.mk build"

And changing __SUNPRO_C to __SUNPRO_CC works!

Comment 3

[Peter Müller]

(In reply to comment #2)

> WS6U2 or higher is required to build. Your compiler version is  Sun C 5.7 Patch
> 117837-06 2005/10/05 .

... but this is $CC

contrary to (config.log)

configure:6641: checking for Forte compiler version >= WS6U2
configure:6652: CC -c -xlibmil -xlibmopt -features=tmplife -norunpath -xbuiltin=%all -features=tmplife -norunpath   -I/usr/openwin/include conftest.C 1>&5
"configure", line 6647: Error: #error "Denied".

where $CXX is used ...

Comment 4

[cls]

Attachment: v1

This check worked originally.  I believe one of the earlier compiler checks changed the compiler used in the test to C++.  We can just set the expected language explicitly to C++ and check the __SUNPRO_CC version since the parts of the tree affected by the test are in C++.

Comment 5

[cls]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1537; previous revision: 1.1536
done

Comment 6

[Leon Sha]

Comment on attachment 201285 [details] [diff] [review]
v1

This bug happened on branch too. It is caused by the latest checkin of configure on branch. I have filed a bug 322549.

Comment 7

[Leon Sha]

*** Bug 322549 has been marked as a duplicate of this bug. ***

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 201285 [details] [diff] [review]
v1

a=dveditz

Comment 9

[Leon Sha]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1503.2.18; previous revision: 1.1503.2.17
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1503.2.15.2.3; previous revision: 1.1503.2.15.2.2
done