Search messages only searches the first message

RESOLVED FIXED

Status

SeaMonkey
MailNews: Message Display
--
major
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Bertram Franz, Assigned: Howard Chu)

Tracking

({fixed1.8.1})

Trunk
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050715 Firefox/1.0.6 SUSE/1.0.6-4.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051027 SeaMonkey/1.1a

When searching messages (either quick search, or Tools->Search Messages), the search criteria are applied only to the first message per folder, and the search results will show zero or one message per searched folder (depending on if the first message matched).

For example, searching for "Sender contains @" in all your folders will return the first message of each folder, but I would expect to see all messages.

Reproducible: Always

Steps to Reproduce:
Type @ in the quick search field
Actual Results:  
Only the first message will remain

Expected Results:  
All messages remain

Self-compiled seamonkey, 20051027 trunk, SuSE9.2, gtk2-2.4.9-10.1, glib2-2.4.6-5, glibc-2.3.3-118, kernel-smp-2.6.8-24.17

Comment 1

13 years ago
I'm only seeing this in a CVS build.  valgrind sees this:

Conditional jump or move depends on uninitialised value(s)
 nsMsgSearchOfflineMail::MatchTerms(nsIMsgDBHdr*, nsISupportsArray*, char const*, nsIMsgSearch
ScopeTerm*, nsIMsgDatabase*, char const*, unsigned, int, nsMsgSearchBoolExpression**, int*) (nsMsgLocalSearch.cpp:616)
 nsMsgSearchOfflineMail::MatchTermsForSearch(nsIMsgDBHdr*, nsISupportsArray*, char const*, nsI
MsgSearchScopeTerm*, nsIMsgDatabase*, nsMsgSearchBoolExpression**, int*) (nsMsgLocalSearch.cpp:363)
 sMsgSearchOfflineMail::Search(int*) (nsMsgLocalSearch.cpp:668)
 nsMsgSearchScopeTerm::TimeSlice(int*) (nsMsgSearchTerm.cpp:1502)
 nsMsgSearchSession::TimeSliceSerial(int*) (nsMsgSearchSession.cpp:700)
 nsMsgSearchSession::TimeSlice(int*) (nsMsgSearchSession.cpp:664)

this is bustage from bug 295088.  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp&rv=1.70#616
err is being used uninitialized.
Assignee: mail → hyc
Status: UNCONFIRMED → NEW
Depends on: 295088
Ever confirmed: true
(Assignee)

Comment 2

13 years ago
Created attachment 201091 [details] [diff] [review]
Fix stupid use of err

Doh... Probably a cut'n'paste error. Try this.
(Assignee)

Updated

13 years ago
Attachment #201091 - Flags: review?(bienvenu)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 3

13 years ago
> Doh... Probably a cut'n'paste error. Try this.

Thanks a lot, problem is fixed.

Comment 4

13 years ago
Comment on attachment 201091 [details] [diff] [review]
Fix stupid use of err

I'll check this in, though I think I'll keep the if (NS_FAILED(err) part the way it is.
Attachment #201091 - Flags: review?(bienvenu) → review+

Comment 5

13 years ago
fix checked in, slightly tweaked.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 6

13 years ago
I assume that this bug was not only PC/Linux, but All/All. If so, please change it.
(Assignee)

Updated

13 years ago
OS: Linux → All
Hardware: PC → All

Comment 7

12 years ago
bug 295088 fix was checked into 1.8.1 branch, so I checked this one in too.
Keywords: fixed1.8.1

Updated

10 years ago
Component: MailNews: Search → MailNews: Message Display
You need to log in before you can comment on or make changes to this bug.