314095 - Eliminate nsIContent::GetDocument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We should replace this with either GetOwnerDoc or GetCurrentDoc (or both if some caller needs both!).

The basic split is:  if the caller is doing something that depends on the DOM, use GetOwnerDoc.  If it depends on the presentation, use GetCurrentDoc.  s/depends on/affects/ if desired

So e.g. nsIDocumentObserver notifications would use the current doc (or both if they're not the same?).

Events are a pain since they need both, in some cases

Security checks... probably the owner doc.  This needs thought in some cases.

Base URIs... owner doc.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I wonder if we should clarify the names a bit. And even adding something that returns what GetCurrentDoc returns now.

Comment 2

[Peter Van der Beken [:peterv]]

(In reply to comment #1)
> And even adding something that returns what GetCurrentDoc returns now.

Why? GetCurrentDoc isn't going to change, is it?

Comment 3

[Peter Van der Beken [:peterv]]

Ignore me ;-). Do we have concrete usecases for such a function though?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_nsIContent_GetDocument.diff

GetUncomposedDoc() is the same as the old GetCurrentDoc(), and
GetComposedDoc() returns a valid value also in case the node is somewhere in
shadow dom which is attached to normal dom subtree which is in document.

https://tbpl.mozilla.org/?tree=Try&rev=cd373d42ec03

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: remove_nsIContent_GetDocument_osx.diff

Additional patch to fix some OSX specific code paths.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 8476757 [details] [diff] [review]
remove_nsIContent_GetDocument.diff

r=jst. We should file bugs on your XXX comments though.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Filed Bug 1057470 for GetElementById, and other XXX have bugs.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: combined

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: combined

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9684e1598f4e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9684e1598f4e