314287 - Change default setting for mousewheel.withmetakey.action

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Ulrik Sverdrup]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051022 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051022 Camino/1.0+

Since just some week back, there is a new default for the the mousewheel.withmetakey.action setting.

Reproducible: Always

Steps to Reproduce:
1. Press and hold the command key to prepare for opening several links in tabs
2. Accidentially or mindlessly scroll with mouse or trackpad

Actual Results:  
Text size changes, sometimes just as a delay before a clicked link is loaded (if the command key is released just before the link click)

Expected Results:  
It shouldn't be this easy to accidentally resize all text on the page.

Notes: I experience this mainly with my trackpad, not my scrollwheel. Lots of macs have a nice double-finger scroll feature, that makes it even easier to do this by mistake.

Also, scrolling can be imprecise when resizing text, especially with the lag of a large page. This makes it even more annoying as it can be hard to get back to exactly the default font size. (Camino also doesn't have a "Normal font size" menu option to go with all the possibilities for resizing the text)

Comment 1

[Ulrik Sverdrup]

I forgot some things, of course.
I suggest that the default key to resize text should be option, not command. It would (perhaps) be more discoverable for a user, too.

Sidenote: filed bug 314289 about the "normal text size" menu item.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mark changed this, I think.  What did the defaults use to be, and why were they changed?

Comment 3

[Mark Mentovai]

See bug 314250.  I'll change this for Camino for sure, but I want to see if there's a consensus on the other bug so I can keep the mappings the same.

Comment 4

[Ulrik Sverdrup]

*** This bug has been marked as a duplicate of 314250 ***

Comment 5

[Samuel Sidler (old account; do not CC)]

Is this really a dupe? I thought they had different implementation points. Mark?

Comment 6

[Mark Mentovai]

Attachment: Puts text size on ctrl and history on option

Comment 7

[Mark Mentovai]

Attachment: Puts text size on ctrl and history on option

Comment 8

[Mark Mentovai]

Comment on attachment 201310 [details] [diff] [review]
Puts text size on ctrl and history on option

Lots of users are complaining that they browse with the command key held and are inadvertently resizing text when operating the mouse wheel.  This patch makes the defaults hopefully less offensive.

Comment 9

[Simon Fraser [no longer active]]

(In reply to comment #8)
> (From update of attachment 201310 [details] [diff] [review] [edit])
> Lots of users are complaining that they browse with the command key held and
> are inadvertently resizing text when operating the mouse wheel.  This patch
> makes the defaults hopefully less offensive.

What about people who keep the control key down (e.g. for context clicks) and suddenly find this patch causing them to go back in history? Can we keep everyone happy?

Comment 10

[Mark Mentovai]

(In reply to comment #9)
> What about people who keep the control key down (e.g. for context clicks) and
> suddenly find this patch causing them to go back in history? Can we keep
> everyone happy?

That's what I'm trying to do!  Control does history now, and nobody's complained about that key, only about command.  Control is being moved to text size here.

Considering the nature of contextual menus, I'd be surprised if people were scrolling around with control held down in the same way that they'd have command down.  And aside from the new touchpads and the mighty mouse with default mappings, most hardware that's got a wheel also has a mouse button dedicated to contextual clicks.

Comment 11

[Ulrik Sverdrup]

Not mentioned, but as we know all key equivalents use command. This has interfered with scrolling a few times for me too.

Reproduce: Scroll down a page, decide you want to reload it. Hitting Cmd-R there is a chance that your other hand hasn't lifted from the trackpad, and you resize the text.

Comment 12

[Mark Mentovai]

I just checked similar behavior in for Firefox on the trunk: control=size, option=history, command=line at a time.  I didn't want to map command to anything in Firefox and still don't want to map it to anything in Camino.

Comment 13

[Mark Mentovai]

Simon, got any strong preferences here?  We've only had complaints from command-holders about text size.

Comment 14

[Simon Fraser [no longer active]]

Comment on attachment 201310 [details] [diff] [review]
Puts text size on ctrl and history on option

Sure.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mark, any reason this hasn't been checked in yet?

Comment 16

[Mark Mentovai]

Yes.  I've been under a rock.  I'll crawl out tomorrow.

Comment 17

[Mark Mentovai]

Fixed on the trunk and a pair of branches.