If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"Enter the path to the file on your computer" assumes I choose a file by entering a path

RESOLVED FIXED in Bugzilla 6.0

Status

()

Bugzilla
Attachments & Requests
--
minor
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Jesse Ruderman, Assigned: Craig Parkinson)

Tracking

unspecified
Bugzilla 6.0

Details

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
When I upload a file, Bugzilla says "Enter the path to the file on your computer".  This is wrong because:
(1) I can also choose a file using a file picker.
(2) If I'm using Safari or Firefox (trunk), I can't enter a path directly.

How about "Select a file on your computer"?
(Reporter)

Comment 1

12 years ago
Created attachment 201304 [details]
screenshot in safari

Updated

12 years ago
OS: MacOS X → All
Hardware: Macintosh → All

Comment 2

12 years ago
some systems let you enter urls to be uploaded... :)
How about "Enter the location of the file on your computer"? B-)
(Reporter)

Comment 4

9 years ago
I think these extra instructions (such as "Select a file on your computer" and "Describe the attachment briefly.") should be removed completely.  They're pretty redundant.

Updated

2 years ago
Whiteboard: [good first bug]

Comment 5

2 years ago
Hello, How do I get the file path for this bug?
Flags: needinfo?(jruderman)

Comment 6

2 years ago
This bug is just about rewording the existing label.
Flags: needinfo?(jruderman)

Comment 7

2 years ago
I think if it was just 

File: 'Choose File' tab. Would be a lot better than "Select a file on your computer" which is superfluous.

Description is pretty much self explanatory so I'd remove "Describe the attachment briefly" and just have "Brief Description" instead. See rough sketch below of my point.

Comment 8

2 years ago
Created attachment 8697534 [details]
Rough Sketch.PNG
Attachment #8697534 - Flags: review?(dkl)
Comment on attachment 8697534 [details]
Rough Sketch.PNG

Looks good to me.
Attachment #8697534 - Flags: review?(dkl) → feedback+
(Assignee)

Comment 10

2 years ago
I'm interested in working on this, would it be possible to take this bug? I've located it so far down to field-label.html.tmpl file. Field labels are generated based upon the id passed in, which in this case is bug_file_loc. However I am unsure where the labels get assigned from there. A hint or two would be appreciated.

Comment 11

2 years ago
(In reply to Craig Parkinson from comment #10)
> I've located it so far down to field-label.html.tmpl file.

This is not the right template. Have a look at attachment/createformcontents.html.tmpl.
(Assignee)

Comment 12

2 years ago
Created attachment 8725597 [details] [diff] [review]
v1.diff

I have kept the link for pasting the attachment as text, thereby keeping the same functionality but removing unnecessary wording.
Attachment #8725597 - Flags: review?(dkl)

Updated

2 years ago
Assignee: attach-and-request → parkcra
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 6.0
Comment on attachment 8725597 [details] [diff] [review]
v1.diff

Review of attachment 8725597 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8725597 - Flags: review?(dkl) → review+
Thanks!

ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   94baad5..f1c21a5  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.