314427 - nsIDOMPopupBlockedEvent should expose the blocked window's target name

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

See http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#421.
Patch coming up.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Looking at the patch again, I suppose windowName should be popupWindowName to match popupWindowFeatures.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 201360 [details] [diff] [review]
patch

- In nsDOMPopupBlockedEvent::GetWindowName(nsAString &aWindowName):

+  if (mEvent->eventStructType == NS_POPUPBLOCKED_EVENT) {
+    nsPopupBlockedEvent* event = NS_STATIC_CAST(nsPopupBlockedEvent*, mEvent);
+    aWindowName = event->mWindowName;
+    return NS_OK;
+  }
+  aWindowName.Truncate();
+  return NS_OK;  // Don't throw an exception

I'd remove the return in the if statement and put the call to truncate in an else...

but r+sr=jst either way with the rename you suggested.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: for checkin

I left the code as it was to match the rest of the file, and this includes the change to nsGUIEvent.h that I forgot to include in the previous file.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/content/events/src/nsDOMPopupBlockedEvent.cpp; new revision: 1.6;
mozilla/dom/public/idl/events/nsIDOMPopupBlockedEvent.idl; new revision: 1.5;
mozilla/dom/src/base/nsGlobalWindow.cpp; new revision: 1.800;
mozilla/dom/src/base/nsGlobalWindow.h; new revision: 1.265;
mozilla/widget/public/nsGUIEvent.h; new revision: 3.126;