314453 - rename *URIChanged

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I think we should rename ImageURIChanged and ObjectURIChanged. These names don't say anything about what these functions do, and are imo hard to understand.

I suggest LoadImage and LoadObject.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: ObjectURIChanged part

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 207137 [details] [diff] [review]
ObjectURIChanged part

r+sr=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: ImageURIChanged part

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/base/src/nsImageLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsImageLoadingContent.cpp,v  <--  nsImageLoadingContent.cpp
new revision: 1.67; previous revision: 1.66
done
Checking in content/base/src/nsImageLoadingContent.h;
/cvsroot/mozilla/content/base/src/nsImageLoadingContent.h,v  <--  nsImageLoadingContent.h
new revision: 1.24; previous revision: 1.23
done
Checking in content/base/src/nsObjectLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v  <--  nsObjectLoadingContent.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in content/base/src/nsObjectLoadingContent.h;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.h,v  <--  nsObjectLoadingContent.h
new revision: 1.8; previous revision: 1.7
done
Checking in content/html/content/src/nsHTMLAppletElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLAppletElement.cpp,v  <--  nsHTMLAppletElement.cpp
new revision: 1.86; previous revision: 1.85
done
Checking in content/html/content/src/nsHTMLImageElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLImageElement.cpp,v  <--  nsHTMLImageElement.cpp
new revision: 1.199; previous revision: 1.198
done
Checking in content/html/content/src/nsHTMLInputElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLInputElement.cpp,v  <--  nsHTMLInputElement.cpp
new revision: 1.419; previous revision: 1.418
done
Checking in content/html/content/src/nsHTMLObjectElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLObjectElement.cpp,v  <--  nsHTMLObjectElement.cpp
new revision: 1.94; previous revision: 1.93
done
Checking in content/html/content/src/nsHTMLSharedElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLSharedElement.cpp,v  <--  nsHTMLSharedElement.cpp
new revision: 1.62; previous revision: 1.61
done
Checking in content/svg/content/src/nsSVGImageElement.cpp;
/cvsroot/mozilla/content/svg/content/src/nsSVGImageElement.cpp,v  <--  nsSVGImageElement.cpp
new revision: 1.17; previous revision: 1.16
done

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does LoadObject really mean LoadPlugin?  I've been thinking we should rename nsObjectFrame to nsPluginFrame now that it doesn't handle all cases of object, but just plugins.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

no, LoadObject can load an image or document as well. it's not specific to nsObjectFrame.

Comment 7

[Håkan Waara]

Assertions like this:

NS_ASSERTION(!mInstantiating, "ObjectURIChanged was reentered?");

probably also needs to change. I just happened to notice this one in nsObjectLoadingContent.cpp

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, not sure how I missed them... fixed:
Checking in nsObjectLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v  <--  nsObjectLoadingContent.cpp
new revision: 1.21; previous revision: 1.20
done
Checking in nsObjectLoadingContent.h;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.h,v  <--  nsObjectLoadingContent.h
new revision: 1.9; previous revision: 1.8
done

Comment 9

[Wayne Woods]

These changes couldn't possibly have caused bug 323283, could they? It was introduced between the 20051231-05 and 20060101-06 builds. There weren't many check-ins in that time period that it could be, so really just guessing.

Comment 10

[Boris Zbarsky [:bzbarsky]]

That bug is caused by AOL being dumb.  Really dumb.