31450 - more threadsafety assertions

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Dawn Endico]

I got these assertions as the psm xpinstall download finished.


###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsXULElement not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsHTMLDivElement not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsTextNode not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: HTMLAttributesImpl not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: ArenaImpl not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsStringBundle not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsPersistentProperties not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372

These happened when I quit.
###!!! ASSERTION: nsPSMUIHandlerImpl not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsSSLSocketProvider not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372
###!!! ASSERTION: nsSocketProviderService not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372

###!!! ASSERTION: nsPSMComponent not thread-safe: 'owningThread ==
NS_CurrentThread()', file nsDebug.cpp, line 372
###!!! Break: at file nsDebug.cpp, line 372

Comment 1

[Dawn Endico]

oops, i meant to say that I was installing psm.

Comment 2

[Warren Harris]

Assigning to dougt.

Comment 3

[mjudge]

I have another location. when I am bringing up phonebook I get the assertion 
from the callstack

nsSSLIOLayerConntect->nsPSMComponent::GetControlConnection(Line500 
NS_WITH_SERVICE).

This looked like a bug tracking these.

Comment 4

[Christine Begle]

i get the same assertion as dawn when entering an ftp url with a user id 
like ftp://cbegle@cx

###!!! ASSERTION: nsWebShellWindow not thread-safe: 'owningThread == 
NS_CurrentThread()', file d:\mo
zsrc\mozilla\xpcom\base\nsDebug.cpp, line 372

Comment 5

[Doug Turner (:dougt)]

--> m16

Comment 6

[Eric Pollmann]

I just saw a ton of threadsafety assertions using today's NT build to visit 
E*Trade.  Notes and a stack trace are available on bug 33367

Comment 7

[Doug Turner (:dougt)]

fixes ready to go.

Comment 8

[Warren Harris]

Remember, fixing these is more than just adding _THREADSAFE to the isupports 
macros. We have to examine why these things are being used on separate threads, 
if that use is legitimate and whether the other methods (besides those from 
isupports) need to be thread-safe too.

Comment 9

[Doug Turner (:dougt)]

fix checked in.  Marking fixed.  

Comment 10

[benc]

Ideas on how to verify this, please.

Comment 11

[benc]

dawn: any chance you can verify this as the reporter?

Comment 12

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old