314628 - Improve discoverability of dock menu bookmarks folder

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, enhancement)

Description

[timeless]

steps:
1. right click "Mac News Tabs"
2. select use as dock menu
3. quit.
4. stop using camino on your computer for a month
5. try using camino again and try to figure out what is being used as your dock menu.

Comment 1

[timeless]

expected results:
possibly right clicking on mac news tabs should at least give me a checked item for use as dock menu ...

Comment 2

[timeless]

smfr complained that my scenario wasn't realistic enough.

here's my actual bookmarks file (that i import just about everywhere):
http://viper.haque.net/~timeless/bookmarks.html

note that i'm likely to decide to make one of those LXR pieces my user as dockmenu bit
and note that there are like six of them all identical.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think timeless's complaint is valid, and I offer this other scenario: I had no idea what was being used as my Dock menu until I first saw bug 244116 and started poking around.  I think the average user is not likely to know what the Dock menu is set as.

Can we change the color of the text (name) of the folder/collection set as the Dock menu to visually indicate "something strange", and then show a tooltip ("This folder or collection is set as your Dock menu.") when hovering over, to explain what the "something strange" really is?

Comment 4

[Stuart Morgan]

Attachment: checks menu item (checked in on trunk and branch)

This will put a checkmark next to the context menu item for "Use as Dock Menu" for the item that is the dock menu.  We should leave this open to consider doing some of the above, but there's no question that we should be doing this.

Comment 5

[Chris Lawson (gone)]

Comment on attachment 244172 [details] [diff] [review]
checks menu item (checked in on trunk and branch)

looks good here.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 244172 [details] [diff] [review]
checks menu item (checked in on trunk and branch)

sr=pink

Comment 7

[Stuart Morgan]

Comment on attachment 244172 [details] [diff] [review]
checks menu item (checked in on trunk and branch)

Checked in on trunk and MOZILLA_1_8_BRANCH

Comment 8

[Markus Amalthea Magnuson]

Seems like this can be closed as it is checked in since long.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We're still considering doing something from comment 3 to make the Dock menu more  visible in the Manager.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you launch Camino and your Dock menu is set to one of the special collections (in real life, only Top 10 at this time due to bug 458995), the checkmark won't be shown until you manually (re)select Top 10 as your Dock menu.

In practical terms, this means on a fresh install of Camino, nothing is checked even though we have defined a Dock menu by default (Top 10) for you.

Comment 11

[Chris Lawson (gone)]

Attachment: sets top10Folder as default if none exists [checked in]

Fixes comment 10.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 342188 [details] [diff] [review]
sets top10Folder as default if none exists [checked in]

This seems to solve the fresh profile case with no obvious side-effects.

Comment 13

[Chris Lawson (gone)]

I've incorporated this fix into bug 458995. There's no real reason they have to be together other than their proximity in code, but there's no real reason not to do both either.

Comment 14

[Chris Lawson (gone)]

Comment on attachment 342188 [details] [diff] [review]
sets top10Folder as default if none exists [checked in]

Clearing review request for now; if we want to land this separately, I can get someone to sr+ it at that point. For now, I'd rather just do this as part of the other bug.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 342188 [details] [diff] [review]
sets top10Folder as default if none exists [checked in]

Since bug 458995 seems to be going nowhere fast, I'd like to see about us pushing just this bit through now.

Comment 16

[Chris Lawson (gone)]

Comment on attachment 342188 [details] [diff] [review]
sets top10Folder as default if none exists [checked in]

re-targeting for sr per comment 15.

Comment 17

[Stuart Morgan]

Comment on attachment 342188 [details] [diff] [review]
sets top10Folder as default if none exists [checked in]

Store the return of [self top10Folder] and use that, rather than calling it twice.

sr=smorgan with that change.

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 342188 [details] [diff] [review]
sets top10Folder as default if none exists [checked in]

Checked in on cvs trunk with smorgan's sr comment addressed.