Closed Bug 314647 Opened 20 years ago Closed 20 years ago

onDownloadShowOptions in toolkit/mozapps/downloads/content/downloads.js is unused (and browser specific!)

Categories

(Toolkit :: Downloads API, defect, P3)

Product:
Toolkit
Component:
Downloads API
Version:
1.8 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8.1beta1

People

(Reporter: Gavin, Assigned: Gavin)

References

(
URL
)

Details

(Keywords: verified1.8.1)

Attachments

(1 file)

patch
1.37 KB, patch
mconnor
: review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review
There are no in-tree callers of this function, so I'm not sure why it exists. Maybe there were plans for an "options" button? Either way, I think it could just be removed, especially since it's dependant on browser.
Status: NEW → ASSIGNED
Attached patch patch — — Splinter Review
Asaf pointed out that there used to be a button but it was removed, so it makes sense to remove the function too.
Attachment #201584 - Flags: review?(mconnor)
Priority: -- → P3
Whiteboard: [patch-r?]
Target Milestone: --- → Firefox1.6-
Attachment #201584 - Flags: review?(mconnor) → review+
mozilla/toolkit/mozapps/downloads/content/downloads.js; new revision: 1.52;
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r?]
Attachment #201584 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #201584 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Whiteboard: [checkin needed]
Whiteboard: [checkin needed] → [checkin needed (1.8 branch)]
mozilla/toolkit/mozapps/downloads/content/downloads.js 1.47.2.7
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 2 → Firefox 2 beta1
Version: Trunk → 2.0 Branch
Verified by code inspection.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: