Closed Bug 314674 Opened 19 years ago Closed 19 years ago

Reporter causes "unknown entity" error (red arrow) after using automatic update to upgrade to RC1

Categories

(Toolkit :: Application Update, defect, P3)

Product:
Toolkit
Component:
Application Update
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jpinscamp, Assigned: benjamin)

References

Details

(Whiteboard: [possibly related to bug 314684, can't reproduce without hitting that bug])

Attachments

(1 file)

Log
13.88 KB, text/plain
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051006 Firefox/1.4.1

will not go away

Reproducible: Always
This is caused by an incompatible extension. To find out which one is causing this you can disable your extensions one by one.
*** Bug 314704 has been marked as a duplicate of this bug. ***
Reporter is not an unsupported extension, and other people are seeing this, (see Asa's RC1 blog post comments).
Summary: after update restart i got a gray bar on the botom of the window with this text in red. <menuitem id="menu_HelpPopup_reportertoolmenu"____^ → Reporter causes "unknown entity" error (red arrow) after using automatic update to upgrade to RC1
Summary: Reporter causes "unknown entity" error (red arrow) after using automatic update to upgrade to RC1 → Reporter causes "unknown entity" error (red arrow) after using automatic update to upgrade to RC1, update fails
this happens after a successful update, correct?
Summary: Reporter causes "unknown entity" error (red arrow) after using automatic update to upgrade to RC1, update fails → Reporter causes "unknown entity" error (red arrow) after using automatic update to upgrade to RC1
Confirming based on multiple comments in other bugs as well as comments from asa's rc1 blog posting (http://weblogs.mozillazine.org/asa/archives/2005/11/firefox_15_firs.html).
Status: UNCONFIRMED → NEW
Ever confirmed: true
This is the message I received

    <menuitem id="menu_HelpPopup_reportertoolmenu"
----^

Thanks to those who have said that it is the reporter extension.  Yes, it did get installed, but I have never bothered to use it.

The question then becomes: Why doesn't firefox clearly state the "module" where the error occurred?

blocking1.8rc2?
Flags: blocking1.8rc2?
I don't know if it has something to do with this bug, but in any case: when I do a custom install of 1.5 b2, randomly the option to install the reportertool is grayed out (but checked). When I go back and choose an other location that option is available again. 
*** Bug 314738 has been marked as a duplicate of this bug. ***
I would like a precise set of step to reproduce this bug: it seems likely to me that this is related to upgrade somehow:

Possible steps I see are:

A: Plain install
 1) Install RC1 using the windows installer

B: beta2 -> RC1: partial update
 1) Install beta2 using the windows installer
 2) update to RC1 using the builtin update mechanism (partial upgrade)

C: beta2 -> RC1: full update
 1) Install beta2 using the windows installer
 2) update to RC1 using the builtin update mechanism (full upgrade, this is hard to test because you get the partial update by default)

D: beta2 -> RC1: installer upgrade
 1) Install beta2 using the windows installer
 2) upgrade to RC1 using the windows installer

If options C and D are broken, but not A or B, I think I know what's going on.
Assignee: nobody → benjamin
bsmedberg:

you can try case C by doing the following:

1. download the partial update.
2. select 'Later' when asked to install it.
3. open 'updates/0' folder and find the 'update.status' file.
4. modify this file to say 'failed'.
5. restart firefox and it will download/install the full update.

i can help test this out after i get off work later today (i'm on lunch break!).
Flags: blocking1.8rc2? → blocking1.8rc2+
I tried A, B and C: no bar at the bottom.
Also D negative. I installed RC1 over the top of beta 2 if this is what you mean.
ugh. Let's go back a step then: will somebody who has this problem please comment with the following items:

1) do you have a <installdir>/extensions/reporter@mozilla.org directory?
2) does it have an install.rdf file within it?
3) do you have a <installdir>/chrome/reporter.manifest file?
4) do you have a <installdir>/chrome/reporter.jar file?
5) does <installdir>/chrome/en-US.manifest have the following line:
  locale reporter en-US jar:en-US.jar!/locale/en-US/reporter/
6) did you ever install the reporter extension manually?

I still need steps to reproduce this :-(
I had deer park & firefox on I removed all and reinstlled firefox 1.5 bata 2 .it updated ok today .
I tried step A ans B from Comment 10 and had no problem.  This includes selcting custom installation and turning on the Website Reporter extension in 1.5B2 and then seeing what upgrade to RC1 would do with this.  It delayed a very long time checking for compatible extensions (~20 minutes!!!) but finally installed 1.5RC correctly.  I will go on to try Step C and D along with trying to reproduce the 20 minute delay.
*** Bug 314848 has been marked as a duplicate of this bug. ***
I tried all steps (A-D) in Comment 10 with a fresh profile and did not see any issues. I will also experiment with a profile that has extensions.
> 1) do you have a <installdir>/extensions/reporter@mozilla.org directory?
No

> 2) does it have an install.rdf file within it?
N/A

> 3) do you have a <installdir>/chrome/reporter.manifest file?
No

> 4) do you have a <installdir>/chrome/reporter.jar file?
No

> 5) does <installdir>/chrome/en-US.manifest have the following line:
>   locale reporter en-US jar:en-US.jar!/locale/en-US/reporter/
No

> 6) did you ever install the reporter extension manually?
No

This is what happened (from memory):

a) I have Beta 2... message told me 1.5 ready for installation and that FireFox will restart.
b) When restarted, Bug reported occured and title bar says 'Mozilla Firefox Beta 2'
c) Went to 'Check for updates' and it gave option to download and install Version 1.5... which I did.
d) Restarted FireFox to complete installation again and Bug still there (although I'm convinced it's slightly different message)
e) If I look at the Help menu now it says that it's 'Downloading FireFox 1.5' and my title bar still says 'Mozilla Firefox Beta 2.

Hope this helps... good luck...
From bug 314684 Comment #52 From Brian Toms 2005-11-02 22:03 PST

Created an attachment (id=201721) [edit]
The weird status bar

The resolution suggested in this bug worked for me, but when the bug was
occuring, I had a weird status bar (see screenshot), no matter what theme I
used.  When I deleted the directory and let Firefox update, the message went
away.


*** Bug 314768 has been marked as a duplicate of this bug. ***
*** Bug 314772 has been marked as a duplicate of this bug. ***
I did not have the reporter extension.  I had linky and google toolbar - the latter one doesn't install because it knows it's incompatible
So the "steps to reproduce" are something like this?:

1) Install 1.0.7
2) Install Beta2
3) Upgrade to RC1 (fails because of bug 314684)
4) The Beta2 installation now has this error message

This would indicate that the updater "revert on failure" code isn't working for some reason. Could someone confirm these steps and attach their update.log (last-update.log)?
Attached file Log — 
No bar :(
In reply to comment #24:

This list of steps-to-reproduce doesn't give the XUL error for me either, regardless of whether I work around bug 314684 or not. Win XP SP2, doing custom installs to a new directory that isn't C:\Program Files\Mozilla Firefox, new profile. Caveat: I haven't ever seen this bug.
Tried also 1.0.4 > 1.0.5 > 1.0.6 > 1.0.7 > 1.5 Beta 1 > updater. Nothing.
*** Bug 314924 has been marked as a duplicate of this bug. ***
Based on the log file, I would say that this is a duplicate of bug 314684.

*** This bug has been marked as a duplicate of 314684 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
premature duping since failure to apply the patch should be enough to trigger bad chrome issues.  reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
*** Bug 314704 has been marked as a duplicate of this bug. ***
I followed the steps in Comment #24 and was not able to reproduce this issue. I started with a 1.0.7 build with a few extensions and did not see any error messages.
(In reply to comment #1)
> This is caused by an incompatible extension. To find out which one is causing
> this you can disable your extensions one by one.
> 

I don't have any extensions installed, but I still have the issue....
(In reply to comment #33)
> (In reply to comment #1)

I didn't read the summary thoroughly enough before answering.
Is your Extensions Manager empty btw?
(In reply to comment #34)
> (In reply to comment #33)
> > (In reply to comment #1)
> 
> I didn't read the summary thoroughly enough before answering.
> Is your Extensions Manager empty btw?
> 
Yes empty.

*** Bug 314977 has been marked as a duplicate of this bug. ***
Looking at Comment #24, it seems as if this might be related to the problem I saw with Talkback.  The moving of the Reporter extension from the previous location to <app dir>/extensions/reporter@mozilla.org might be causing problems for users going from 1.0.x to 1.5.x (see https://bugzilla.mozilla.org/show_bug.cgi?id=311717).  I needed to clean up some old files from 1.0.x in order to get Talkback working properly in 1.5.x.  

I might be way off, but just wanted to throw that out there in case we need to do the same for Reporter.
It appears that Reporter has moved back to chrome between 1.8b5_2005101816 and 1.8b5_2005101907 (that is right between the last two versions  I believe), but whatever I try, I can't make it show any errors.
(In reply to comment #37)
> I needed to clean up some old files from 1.0.x in order to
> get Talkback working properly in 1.5.x.  
> I might be way off, but just wanted to throw that out there in case we need to
> do the same for Reporter.

Seems unlikely, especially given comment #27...

This is probably silly, but has anyone actually checked whether this happens in safe mode? Maybe reporter is not playing well with another extension. Or maybe another extension is interferring with reporter... 
(In reply to comment #39)
> (In reply to comment #37)
> > I needed to clean up some old files from 1.0.x in order to
> > get Talkback working properly in 1.5.x.  
> > I might be way off, but just wanted to throw that out there in case we need to
> > do the same for Reporter.
> 
> Seems unlikely, especially given comment #27...
> 
> This is probably silly, but has anyone actually checked whether this happens in
> safe mode? Maybe reporter is not playing well with another extension. Or maybe
> another extension is interferring with reporter... 
> 
Once again, I don't even have any extensions and I'm having this problem.
I'm getting this after the upgrade 1.5 beta 2

previous version was 1.5 beta 1, previous version before that was 1.05 i think.
(the firefox upgrader did the upgrade)

standard extensions set include:

DOM Inspector 1.8b5
Reporter 1.8b5
Tallback 1.4.1

standard themes
standard mozilla after that

I'm also getting that endless upgrade loop aswell as in bug #314684
looks like this can't impact the 1.0.x -> 1.5. Not going to block on this.
Flags: blocking1.8rc2+ → blocking1.8rc2-
(In reply to comment #42)
> looks like this can't impact the 1.0.x -> 1.5. Not going to block on this.
> 

This has a major impact.  The problem is that if you install 1.5.anything over 1.0.anything WITHOUT unistalling the 1.0.x version first, you are creating a timebomb which results in Firefox getting completely hosed the next time it auto updates.

Steps to reproduce.

1.  Install Firefox 1.0.7 release in an empty directory
2.  Launch Firefox 1.0.7 using a fresh profile.
3.  exit firefox
4.  Install Firefox 1.5 beta2 to the same directory as 1.0.7 was WITHOUT unstalling 1.0.7 first.
5.  Lauch Firefosx 1.5 beta2.
6.  Select Help -> Check for Updates and install the update.

Result is either the reporter issue, the intsall loop or both.
Severity: normal → major
(In reply to comment #43)
I tried this tenths of times. Could not reproduce. But I had no old polluted 1.0.7 profile to try it on. Maybe the next update should be: uninstalling the previous version first, then installing the next one. Or using a totally new directory.:)
Uninstalled, then re-installed 1.5 beta 2. Leaving it there until I hear there's a fix or newer version.
(In reply to comment #45)
> Uninstalled, then re-installed 1.5 beta 2. Leaving it there until I hear
> there's a fix or newer version.
> 

You should be able to unistall, delete the folder where you installed Firefox (Usually c:\Program Files\Mozilla Firefox) and re-install 1.5 beta.  Form that point forward updates should work just fine.  From my testing it appears to only be necessary to remove any vestages of the previous 1.0.X install form the applications folder to avoid the issue.
Priority: -- → P3
Whiteboard: [possibly related to bug 314684, can't reproduce without hitting that bug]
For future reference, if someone can cc me on reporter related bugs (that aren't in one of the two reporter components, client/server) I'd appreciate it.  Makes life a little easier knowing what goes on outside my cardboard box.
*** Bug 315408 has been marked as a duplicate of this bug. ***
The problem is caused by an older version of en-US.jar remaining in the chrome folder.  You can reproduce this error using the latest 1.5RC1 (make a backup of en-US.jar first) by overwriting it with the version dated 2005.11.02 17:42 - this one can be downloaded from   http://62nds.com/en-US.jar 
(In reply to comment #49)
> The problem is caused by an older version of en-US.jar remaining in the chrome
> folder.  You can reproduce this error using the latest 1.5RC1 (make a backup of
> en-US.jar first) by overwriting it with the version dated 2005.11.02 17:42 -
> this one can be downloaded from   http://62nds.com/en-US.jar 
> 
Sorry, forget about the date/time mentioned. The file is 578530 bytes.

(In reply to comment #50)
I can reproduce this and I see the bar with the error now.
So while updating 1.5 beta 2 versions the updater has deleted the reporter@mozilla.org extension and added the reporter.jar and reporter.manifest and then stopped. :?
See also https://bugzilla.mozilla.org/show_bug.cgi?id=315408#c4

5) does <installdir>/chrome/en-US.manifest have the following line:
  locale reporter en-US jar:en-US.jar!/locale/en-US/reporter/
[rs23] No.


So the problem is, that when the update is not successful for some reason, the updater does not "undo"?
So I wondered why I did not get the ugly bar at the bottom and I see that the difference is, that the updater does not remove my reporter@mozilla.org extension but it does add the reporter.jar and reporter.manifest in the chrome folder.
So the presence of that extension hides the problem.
When I remove the extension I see the bar.
Based on my testing, I would say this bug is a manifestation of the issue raised in bug 315603.

Setting a dependency.
Depends on: 315603
*** Bug 315807 has been marked as a duplicate of this bug. ***
*** Bug 309495 has been marked as a duplicate of this bug. ***
*** Bug 316081 has been marked as a duplicate of this bug. ***
I have upgraded from 1.5beta2 to 1.5 RC2
I had previuosly updated from 1.07 (or similar) to 1.5beta2
I have upgraded to 1.5 RC2 clicking on the  1.5 RC2 xpi

This menu_HelpPopup_reportertoolmenu message on a thick bottombar appeared after first run. 

It continue when running in safe mode as a normal or Administrator user.
Also with all extension disable one by one (I presume should be the same effect)

Saddly it is a critical bug that cannot go into 1.5 final. Not because of its severity but because of its ugliness and lose of an extre 1/6 of screen real estate.

I have checked the chrome directory and found that all the files have the same date except en-US.jar and en-US.manifest 
which are older (date is lost since I did manually moved the files later for debugging after reading former comment) and therefore belonging to an older  
installation (presume 1.5b2), and the files pipnss.jar and inspector.jar which are even older (presume 1.07, from september)

Is it that en-US.jar was not overwritten with the new version? Should I overinstall rc2? 
(In reply to comment #60)
If you delete/empty your install directory and install 1.5rc2, all will work fine.

(In reply to comment #61)
> (In reply to comment #60)
> If you delete/empty your install directory and install 1.5rc2, all will work
> fine.
> 

I had installed the update using an xpi (not an exe)
I guess it could not overwrite all the needed files (locking problem) since it did not shut firefox down.

Now I tried to overinstall with the exe installer. all files in the chrome directory were overwritten this time (including the en-US.jar.*) though the pipnss.jar and inspector.jar were not deleted.

Problem has disappeared.
*** Bug 316308 has been marked as a duplicate of this bug. ***
*** Bug 318261 has been marked as a duplicate of this bug. ***
*** Bug 318239 has been marked as a duplicate of this bug. ***
*** Bug 318237 has been marked as a duplicate of this bug. ***
*** Bug 318172 has been marked as a duplicate of this bug. ***
*** Bug 318399 has been marked as a duplicate of this bug. ***
Attention triagers: bsmedberg asked on IRC for anyone with this problem to set javascript.options.showInConsole to true, then look for errors in the Javascript console.
This seems to happen as well for users upgrading from 1.0.x
It's important to not confuse this specific bug with other general extension problems just because the symptoms are the same. Some of the recent dupes could easily have been something else, and without waiting for the reporter to respond it's impossible to know.
Bug 319319 looks pretty similar and has some JS Console output
As per mconnor marking this bug worksforme as Reporter is no longer an extension and further updates shouldn't cause this problem.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → WORKSFORME
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: