314755 - sanitization at shutdown sometimes fails (resulting in a confirmation dialog for clearing private data when firefox starts)

Status: NEW

(Firefox :: General, defect)

Description

[Dominik Krauss]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; de; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; de; rv:1.8) Gecko/20051025 Firefox/1.5

Everytime when I start Firefox 1.5 RC1 the option menu for clearing private data appears, although nothing exist that can be cleared, because the data was cleared at the end of the last session. When I used Beta 2, it didn't appear.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox 1.5 RC1



Expected Results:  
The option menu should only appear when firefox will be closed

Comment 1

[Asaf Romano (gone)]

I was able to reproduce this in today's branch build, the Cookies cleanup seems to fail on-profile-change.

Comment 2

[four12]

Does it for me too on 1.5RC1

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5

Comment 3

[Scott MacGregor]

Ben, can you take a look at this?

Comment 4

[Adam Guthrie]

The patch for bug 307840 was supposed to fix this. :(

Comment 5

[Sokraates]

I can't reproduce this. My preferences are the default ones, except for passwords never being saved and cookies being cleared when closing FF.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051102 Firefox/1.5 ID:2005110203

Comment 6

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051102 Firefox/1.5 ID:2005110218

WFM. Is there a special combination of items to be cleared that I should check? 

Comment 7

[Dominik Krauss]

My preferences are also the default ones (all private data except cookies and passwords) except firefox should ask at the end of a session for clearing private data. I didn't change my profile since I have switched from Beta 2 to RC1.

Comment 8

[Sokraates]

This seems to be a Mac-only problem. I didn't have "Clear private data when closing Firefox" activated before. Clearing cookies when closing FF was activated in the "Cookies"-tab.

So I just went to Tools -> Options -> Privacy -> Settings and checked "Clear private data when closing Firefox" and "Ask me before clearing private data". 

Closed FF and it worked like a charm.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051102 Firefox/1.5 ID:2005110203

Comment 9

[Sokraates]

(In reply to comment #1)
> I was able to reproduce this in today's branch build, the Cookies cleanup seems
> to fail on-profile-change.
> 

WFM. What system do you use?

Tried all possible settings in the "Cookies"-tab in combination with "Clear private data", then tried it with "until I close FF" without "Clear private data". Worked every time. 

Could it be, that you found Google's cookies? The default FF-startpage automatically redirects you to Google, so you'll have those on every start-up.

Comment 10

[Frosch]

I'm running Windows XP and the bug occurs here as well. Checking "Clear private data when closing firefox" and "Ask me before clearing private data" doesn't actually result in asking me what to do when closing firefox but when opening it. I'm using the official rc1.

Comment 11

[Mike Schroepfer]

Giorgio,  is there a chance you could take a look at this?

Comment 12

[Giorgio Maone [:ma1]]

I'll take a look tomorrow.(In reply to comment #4)
> The patch for bug 307840 was supposed to fix this. :(
> 
There were be other patches after that bug have been fixed.
I'll take a look tomorrow.

Comment 13

[Marcia Knous [:marcia]]

I tried literally dozens of different combinations to try to reproduce this on the RC1 Mac build, and I wasn't able to. It would be helpful if the reporter or others can include an additional information regarding steps to reproduce.  Are you all using existing profiles?(I saw something in Mano's comment about profile switching).  Any cookie related extensions installed?  When you get the dialog at the end of the Firefox session, did you click the button to clear or did you quit Firefox without doing so?  In the build I was using, I was able to get the quit Firefox, get the Clear Private Settings dialog and then exit Firefox from the menu without actually clearing out all of my settings. But when I launched again I did not see the Clear Private Settings dialog.

Comment 14

[Frosch]

> It would be helpful if the reporter or
others can include an additional information regarding steps to reproduce.

And here it is (on Windows XP):
1. Uninstall Firefox 1.0.7
2. Install Firefox rc1 (using the existing profile of Firefox 1.0.7, i think rc1 uses the old Firefox 1.0.7 profile, even after uninstalling, doesn't it?)
3. Don't do anything except changing these options, i.e. check "Clear private
data when closing firefox" and "Ask me before clearing private data".

Btw., i never made any changes to any cookie settings or whatsoever. My only installed extension is Forecastfox. This doesn't seem to be the reason for this problem, though, as on my linux box the bug doesn't occur with Forecastfox installed.

> When you get the
dialog at the end of the Firefox session, did you click the button to clear or
did you quit Firefox without doing so?

There never was a dialog at the end of any Firefox session. It only appears after actually starting Firefox...every time.

Comment 15

[Marcia Knous [:marcia]]

Okay, so I followed these steps to the letter on both Windows and Mac and still can't reproduce.  Here is what I did on Windows:

1. Created a 1.0.7 profile. Added the Forecast Fox extension. Built up some cookies.
2. Installed RC1 build on top of 1.0.7
3. Went to Tools | Options  to the Clear private data settings. Selected the option that says "Clear Private data when closing Firefox"  As far as the other setting, it depends on what boxes are checked - in my case the option for "As me was greyed out." It seems that the only way the "Ask me" option becomes active is if the "Saved Passwords" box is unchecked.  When that happens, I see the "Ask me before clearing private data" box become active.

In any case, I was not able to reproduce the issue. After checking those boxes and closing Firefox, I do get the window that asks me if I want to clear the data. And when Firefox starts up again, I don't see the option dialog again, whether I click cancel or actually clear the data.

Frosch, can you please take a screenshot of what your clear private data settings look like after you launch RC1? Might be easier for me to see which boxes are checked/unchecked.

(In reply to comment #14)
> > It would be helpful if the reporter or
> others can include an additional information regarding steps to reproduce.
> 
> And here it is (on Windows XP):
> 1. Uninstall Firefox 1.0.7
> 2. Install Firefox rc1 (using the existing profile of Firefox 1.0.7, i think
> rc1 uses the old Firefox 1.0.7 profile, even after uninstalling, doesn't it?)
> 3. Don't do anything except changing these options, i.e. check "Clear private
> data when closing firefox" and "Ask me before clearing private data".
> 
> Btw., i never made any changes to any cookie settings or whatsoever. My only
> installed extension is Forecastfox. This doesn't seem to be the reason for this
> problem, though, as on my linux box the bug doesn't occur with Forecastfox
> installed.
> 
> > When you get the
> dialog at the end of the Firefox session, did you click the button to clear or
> did you quit Firefox without doing so?
> 
> There never was a dialog at the end of any Firefox session. It only appears
> after actually starting Firefox...every time.
> 

Comment 16

[Dominik Krauss]

I haven't installed any additional extensions or themes. I uninstalled FF 1.5 Beta2 and then I installed RC1. And since then everytime when I start or close Firefox the option menu appears. The combination of checked boxes seems to be trivial (I had tested all combinations, even no data is selected). I have only to check that FF clears private data and that FF asks for it. And it is also trivial if I clear private data at the end of the session or not.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

To clear up some of the confusion, the sanitize dialog is designed to try again at startup if sanitizing on shutdown failed, so the bug here is that the Cookie sanitization is failing on shutdown. It would be possible to prevent having that dialog appear each and every time Firefox is started, but that wouldn't fix the underlying issue of the Cookies not being cleared on shutdown.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Does anyone who sees this problem see a "privacy.sanitize.didShutdownSanitize" pref in about:config? Does clearing that pref (right click, reset) fix the problem?

Comment 19

[Giorgio Maone [:ma1]]

(In reply to comment #18)
> Does anyone who sees this problem see a "privacy.sanitize.didShutdownSanitize"
> pref in about:config? Does clearing that pref (right click, reset) fix the
> problem?
> 

That preference *not* being set is actually supposed to trigger the dialog on startup (provided that privacy.sanitize.sanitizeOnShutdown and privacy.sanitize.promptOnSanitize are bot true).

Not able to reproduce yet on today's 1.8 branch.
A sample profile from someone who's experiencing this problem may help.

Comment 20

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #19)
> That preference *not* being set is actually supposed to trigger the dialog on
> startup (provided that privacy.sanitize.sanitizeOnShutdown and
> privacy.sanitize.promptOnSanitize are bot true).

Yes, I realize that now. I thought there was a flaw with the pref checking, since I didn't see where it was ever cleared, but that obviously would have caused more serious issues.

This sounds like it could be a regression from bug 269799. Ben originally deleted manually instead of using removeAll, possibly because there was something wrong with removeAll. It would be good to understand why he used that method in the first place.

Comment 21

[Christian Stewart]

(In reply to comment #18)
> Does anyone who sees this problem see a "privacy.sanitize.didShutdownSanitize"
> pref in about:config? Does clearing that pref (right click, reset) fix the
> problem?
> 

privacy.sanitize.didShutdownSanitize pref is there, but with no value, therefore unable to reset.

Happy to share profile - reproduced on Mac OSX 10.4.3, clean install having deleted 1.07 and renamed Firefox folder in /user/library/application support before 1.5rc1 install.

Comment 22

[Jo Hermans]

Attachment: my profile

confirmed with todays build on Mac OS X 10.2.8
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107 Firefox/1.5

here's a copy of my profile

Comment 23

[Christian Stewart]

Attachment: User Profile after Confirm Clear in Clear Private Data Window on Quit

My prefs.js file with Firefox shut down and after quitting and selecting "Confirm" in the CPD window.  CPD window reappears again on startup, regardless of selection on Quit (Confirm, Cancel or click on close window button). prefs.js file remains identical regardless of "Confirm" or "Cancel" on quit.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025 Firefox/1.5 on Mac OSX 10.4.3 Build 8F46

Comment 24

[Jo Hermans]

Note that I wasn't running any extension, not even Adblock (some people reported on Asa's blog that it's linked to Adblock).

Comment 25

[Marcia Knous [:marcia]]

I have been able to reproduce this on the Mac with Adblock, but as Jo points out, others have seen it without extensions.

Here are a set of exact STR on the Mac (with Adblock).

1.  Create a 1.0.7 profile with some cookies, etc. Installed the Adblock extension.
2.  Using the same profile, launch the RC1 build.
3.  Go into Tools | Clear Private data and clear your settings. Quit Firefox.
4.  Upon launch I see the Clear Private data dialog

Comment 26

[dex_sf]

On Mac OS X v10.4.3 I was able to reproduce the bug each time I tried it with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107 Firefox/1.5 ID:2005110703:

1. create a new profile and start Fx, let "What's new" page load
2. go to preferences/privacy/settings and check clear data when closing Firefox, click ok, shut Preferences
3. quit Fx
4. cancel question if private data should be cleared
5. start Fx with same profile
6. after Firefox Start/Google page is loaded, click on "Getting Started" bookmark and let the page load
7. quit Fx
8. cancel question if private data should be cleared
9. start Fx with same profile
10. clear private dialog appears at start of Fx from now on

On Win XP that steps do not reproduce the bug though.

Comment 27

[Frank]

> 1.  Create a 1.0.7 profile with some cookies, etc. Installed the Adblock
> extension.
> 2.  Using the same profile, launch the RC1 build.
> 3.  Go into Tools | Clear Private data and clear your settings. Quit Firefox.
> 4.  Upon launch I see the Clear Private data dialog

Those STR also work on Windows with 1.8rc1. I haven't seen it without having AdBlock installed though.  

Comment 28

[Marcia Knous [:marcia]]

On the Mac, I am noticing that after I invoke the "Clear Private Data" from the tools menu and clear the settings, Firefox does not seem to qui properly.  I select "Quit Firefox" from the menu and the window closes, but Firefox still seems to be running and I have to quit the process from the icon in the dock.

Comment 29

[dex_sf]

(In reply to comment #28)
> On the Mac, I am noticing that after I invoke the "Clear Private Data" from the
> tools menu and clear the settings, Firefox does not seem to qui properly.  I
> select "Quit Firefox" from the menu and the window closes, but Firefox still
> seems to be running and I have to quit the process from the icon in the dock.

That happens on my system as well. But since only the window is closed I can click on "Firefox" and "Quit Firefox" a second time and then it shuts down completely. 

Comment 30

[Marcia Knous [:marcia]]

Gavin: Interestingly enough, in my about:config the pref is there but it is not set to any value.

(In reply to comment #18)
> Does anyone who sees this problem see a "privacy.sanitize.didShutdownSanitize"
> pref in about:config? Does clearing that pref (right click, reset) fix the
> problem?
> 

Comment 31

[Christian Stewart]

(In reply to comment #26)

1. Move Firefox 1.07 Application to Trash
2. Rename /user/library/application_support/firefox folder 
3. Install Firefox 1.5rc1
4. Start, then immediately go to preferences, private, settings and check Clear private data when closing Firefox
5. Quit Firefox
6. Select either Confirm or Cancel or close the CPD window manually
7. Restart Firefox and CPD window reappears before browser window.

Always reproduceable

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025
Firefox/1.5 on Mac OSX 10.4.3 Build 8F46

Comment 32

[Marcia Knous [:marcia]]

Dex: I tried your exact set of steps on the Mac I am testing on and didn't see the problem. Do you have any extensions installed? I was using the most recent Firefox build that just came out - 20041107-12. I am trying to get to a set of steps where we can repro without extensions.

(In reply to comment #26)
> On Mac OS X v10.4.3 I was able to reproduce the bug each time I tried it with
> Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107
> Firefox/1.5 ID:2005110703:
> 
> 1. create a new profile and start Fx, let "What's new" page load
> 2. go to preferences/privacy/settings and check clear data when closing
> Firefox, click ok, shut Preferences
> 3. quit Fx
> 4. cancel question if private data should be cleared
> 5. start Fx with same profile
> 6. after Firefox Start/Google page is loaded, click on "Getting Started"
> bookmark and let the page load
> 7. quit Fx
> 8. cancel question if private data should be cleared
> 9. start Fx with same profile
> 10. clear private dialog appears at start of Fx from now on
> 
> On Win XP that steps do not reproduce the bug though.
> 

Comment 33

[dex_sf]

No extensions, I created a new, absolutely clean profile each time I tried it (1. step), I used build 2005110703 though. And with step 10 the confirmation dialog for clearing private data appeared at the start of Fx as well as when I quit it. I tried the procedure several times, and got always the same result.

Dex
 


(In reply to comment #32)
> Dex: I tried your exact set of steps on the Mac I am testing on and didn't see
> the problem. Do you have any extensions installed? I was using the most recent
> Firefox build that just came out - 20041107-12. I am trying to get to a set of
> steps where we can repro without extensions.

Comment 34

[dex_sf]

Updated to build 2005110712, went through the procedure again with the same result: the confirmation dialog for clearing private data appeared at the start of Fx as well as when I quit it.

Dex



(In reply to comment #33)
> No extensions, I created a new, absolutely clean profile each time I tried it
> (1. step), I used build 2005110703 though. And with step 10 the confirmation
> dialog for clearing private data appeared at the start of Fx as well as when I
> quit it. I tried the procedure several times, and got always the same result.
> 
> Dex
> 
> 
> 
> (In reply to comment #32)
> > Dex: I tried your exact set of steps on the Mac I am testing on and didn't see
> > the problem. Do you have any extensions installed? I was using the most recent
> > Firefox build that just came out - 20041107-12. I am trying to get to a set of
> > steps where we can repro without extensions.
> 

Comment 35

[Giorgio Maone [:ma1]]

Attachment: Forces preferences flush after sanitization

(In reply to comment #23)

> prefs.js file remains identical regardless of "Confirm" or "Cancel" on quit.
> 
> Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025
> Firefox/1.5 on Mac OSX 10.4.3 Build 8F46
> 

This is an interesting report: looks like something happens (not at the JavaScript level, since hitting "Cancel" doesn't lead to a path which can reasonably throw exceptions) which prevents preferences from being flushed. Maybe some kind of "silent" crash, likely silent because there's no more UI left.
There's a quick way to check my theory: can someone experiencing this problem apply the attached patch and retest?
TIA

Comment 36

[Scott MacGregor]

I found a very easy way to reproduce this in the debugger on Windows. Make sure you've checked clear private data on shutdown and prompt before clearing private data.

On a windows debug build if I kill the process while it's running and then restart Firefox, I get the dialog on startup. This simulates a case where users are quitting the app on the Mac and for some reason we aren't properly shutting down. That leaves us in a bad state so on startup again we try to clear the private data. 

Comment 37

[Jesse Ruderman]

Scott, I think the dialog is intentional in that case.  The question is why the dialog is appearing for some Mac users who haven't seen a crash dialog.

Comment 38

[Scott MacGregor]

My debug Mac OS X build is showing me a couple of warnings / errors in the console. 

1) When quitting, after choosing to clear private data I get the following JS Exception:

************************************************************

* Call to xpconnect wrapped JSObject produced this error:  *

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: observe :: line 637"  data: no]

************************************************************


the process does cleanly exit. When I restart and launch again, I get the clear private data dialog again of course and this time I see the following error in the console:

WARNING: ERROR: Form history file is corrupt, now deleting it., file nsFormHistory.cpp, line 498

Maybe that will help Beng/Giorgio figure out what's going on.

Comment 39

[Drew J. Como]

Now, I am running the nightly builds on both a Windows XP and Mac (OS 10.4/Tiger) and am only seeing this problem on the Mac.  (Even though the version numbers are identical.)

I thought maybe a configuration option was incorrectly set or that my installed version was corrupted, so I tossed the executable and re-installed it.  Unfortunately, this did not clear up the problem.

If there is any special type of debugging that is needed (special build or runtime parameters), please let me know!  (I'd love to help track this bug down!)

Comment 40

[Giorgio Maone [:ma1]]

Did anybody experiencing this problem try to apply my patch (attachmend 202168)?
If answer is no because nobody who's affected can recompile Firefox, you patch it "live" following these simple steps:

1.. Close Firefox
2.. Locate the FIREFOX_HOME/Components directory
3.. Delete the compreg.dat file you find there
4.. Edit the nsBrowserGlue.js file (there too), sarching for the

   get Sanitizer()

statement (should be at line 125) and replacing it up to the

   return Sanitizer;

statement (line 132) with:

// --- START ---
  get Sanitizer() 
  {
    if(typeof(Sanitizer) != "function") {
      Components.classes["@mozilla.org/moz/jssubscript-loader;1"]
                .getService(Components.interfaces.mozIJSSubScriptLoader)
                .loadSubScript("chrome://browser/content/sanitize.js", null);
      Sanitizer._checkAndSanitize = function() 
      {
        const prefs = Sanitizer.prefs;
        if (prefs.getBoolPref(Sanitizer.prefShutdown) && 
            !prefs.prefHasUserValue(Sanitizer.prefDidShutdown)) {
          // this is a shutdown or a startup after an unclean exit
          if(!Sanitizer.sanitize(null)) { 
            prefs.setBoolPref(Sanitizer.prefDidShutdown, true);
            prefs.savePrefFile(null); 
          }
        }
      };
    }
    return Sanitizer;
// --- END ---

5.. Start Firefox

Good luck and let me know.

Comment 41

[Rick Friedman]

I am running 1.5 rc1 on Debian Linux. I have the Clear Private Data settings set as follows:

    Browsing History, Download History, Cache and Authenticated Session will be cleared.

I have Clear private data when closing firefox set on.
I have Ask me before clearing private data set on.

When I close firefox, I do not get the Clear Private Data dialog. As a matter of fact, while the firefox window disappears, the actual firefox process is still running. I have to manually use the Linux "kill" command to end the firefox process. Running Firefox in a from the command line displays no errors. It simply sits there after closing the Firefox window until I kill it.

Comment 42

[Christian Stewart]

Giorgio, not up to recompiling Firefox, but happy to try editing files as described.  However your instructions seem to be for Windows builds, I can't find nsBrowserGlue.js in my Mac OSX 10.4.3 version.  Any pointers? 

(In reply to comment #40)
> Did anybody experiencing this problem try to apply my patch (attachmend
> 202168)?
> If answer is no because nobody who's affected can recompile Firefox, you patch
> it "live" following these simple steps:
>..........

Comment 43

[Scott MacGregor]

Giorgio, your patch did not effect what I'm seeing on the Mac at all. I still got the same JS errors in the console about session history and form history. 

And when I restarted, I still got reprompted to clear private data.

Comment 44

[Scott MacGregor]

When clearing private data on shut down, I saw a couple more errors which could be significant including:

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsGlobalHistory.cpp, line 2595

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(OpenDB())) failed, file nsGlobalHistory.cpp, line 1252

Comment 45

[Scott MacGregor]

I suspect by the time we are starting to clean up the private data on exit, xpcom has started to unload the various services and components. That would explain why the falling call is failing:

rv = NS_GetSpecialDirectory(NS_APP_HISTORY_50_FILE, getter_AddRefs(historyFile));
NS_ENSURE_SUCCESS(rv, rv);

http://lxr.mozilla.org/mozilla1.8/source/toolkit/components/history/src/nsGlobalHistory.cpp#2594

We may have to release note this issue for 1.5 with a comment about not using Clear Private Data on exit on the Mac. 

Comment 46

[José Jeria]

(In reply to comment #45)
> We may have to release note this issue for 1.5 with a comment about not using
> Clear Private Data on exit on the Mac. 

Would it be possible to remove that option on the mac? 

Comment 47

[Asaf Romano (gone)]

Attachment: hide the option on OS X for 1.5

Comment 48

[Mike Connor [:mconnor]]

Comment on attachment 202285 [details] [diff] [review]
hide the option on OS X for 1.5

I don't know if we can take this now, but its really the right thing...

Comment 49

[:Gavin Sharp [email: [e-mail]]]

Wouldn't it be better to instead disable the startup-warning for macs? Form clearing on shutdown would still be broken, but at least some of the functionality would remain. You could just ifdef out the "onStartup" in sanitize.js for macs.

Comment 50

[Asaf Romano (gone)]

That would remain a privacy issue if we do so.

Comment 51

[Marcia Knous [:marcia]]

I know we have been focusing on the Mac specific stuff for this bug, but what about the fact that Windows users have seen it as well? If we could get a good set of steps to repro on Windows that would help.  Any Windows users that reported seeing this, please give us the exact set of steps to reproduce.  thanks.

Comment 52

[:Gavin Sharp [email: [e-mail]]]

I think that due to this bug's summary, people are getting confused as to what the bug really is. Having the dialog appear on startup after sanitization fails (e.g. crash, killing the process, reboot the computer) is intended, if Firefox is configured to clean up on shutdown. This bug is that sanitization is failing when it shouldn't. Mac is seemingly more susceptible to this failure, possibly because of the way it uses a hidden window, but apparently Adblock also causes such failures cross-platform, which could explain the Windows cases.

Comment 53

[Christian Stewart]

On a clean Windows install the bug does not appear for me.  However to clarify the contents of prefs.js after shutdown may be useful.  

With on both Windows build (No Bug) and Mac build (Bug) shutdown (Confirm or Cancel) "user_pref("privacy.sanitize.didShutdownSanitize", true);" appears.  

In Windows build (No Bug) go to task manager whilst Firefox is running and kill firefox.exe.  CPD window does not appear and there is no "user_pref("privacy.sanitize.didShutdownSanitize", true);" entry either true or false. Restart Firefox and CPD window appears

Comment 54

[Christian Stewart]

Clean Windows Install (remove 1.07, rename any Firefox Profile folders, remove programs folders).  
Install 1.5rc1, select CPD from options. Close Firefox, CPD window appears. Firefox opens cleanly.

Check prefs.js whilst Firefox closed and user_pref("privacy.sanitize.didShutdownSanitize", true); appears in prefs.js regardless of Confirm or Cancel being chosen on exit in CPD window.

Install Adblock 0.5.2.039 and close Firefox. CPD does not appear. Open Firefox and CPD appears.

Check prefs.js whilst Firefox closed and user_pref("privacy.sanitize.didShutdownSanitize", true); does not appear.

Comment 55

[Giorgio Maone [:ma1]]

    (In reply to comment #53)
    > With on both Windows build (No Bug) and Mac build (Bug) shutdown (Confirm or
    > Cancel) "user_pref("privacy.sanitize.didShutdownSanitize", true);" appears.  

    Again, Christian's comment is enlighting, *if confirmed by other affected people*.

Sanitization on shutdown actually works (notwithstanding exceptions), managing to set the didShutdownSanitize property even where bug happens. This would mean that it's on startup that this property could't be read properly.

Can the check in for bug bug 311086 (the "final-ui-startup" stuff) have some subtle side effect on Mac OS X (maybe http://lxr.mozilla.org/mozilla1.8/source/toolkit/xre/nsAppRunner.cpp#2252 is worth a look)?

Comment #54 AdBlock then would reference to an unrelated, extension caused problem preventing preference from being set on shutdown.

Comment 56

[Frank Yan (:fryn)]

I have Adblock Plus 0.5.10+ and I dont see it

Comment 57

[Rick Friedman]

(In reply to comment #41)
> I am running 1.5 rc1 on Debian Linux. I have the Clear Private Data settings
> set as follows:
 
> When I close firefox, I do not get the Clear Private Data dialog. As a matter
> of fact, while the firefox window disappears, the actual firefox process is
> still running. I have to manually use the Linux "kill" command to end the
> firefox process. Running Firefox in a from the command line displays no errors.
> It simply sits there after closing the Firefox window until I kill it.

After more research, I found that the problem (at least on the Linux side) seems to stem from the Adblock extension (v0.5 d2 Nightly * build 39). Once the Adblock extension is disabled, clearing private data seems to work perfectly. Re-enabling Adblock causes the problem, as described above, to reoccur.

Comment 58

[Asa Dotzler [:asa]]

we're going to release note this and look to the follow-up release for a fix. 

Comment 59

[Tim Meader]

At this point, AdBlock Plus really ought to be the version used anyhow. Perhaps put a link in the release notes directly people to AdBlock Plus as a compatible replacement (in addition to the superset of features it has over standard AdBlock)?

Comment 60

[ryan.hennessey]

This is my first time reporting a bug.  followed a link from a blog and I got here. Hopefully it's the right spot.

I recreated the bug where the clear private data operation occurs on startup rather than shut down.  The following is what I did.  It's more involved that the previous example, but maybe it'll help anyway

1. Was running firefox 1.0.7, upgraded to 1.5RC2
2. closed and restarted firefox a few times
3. Installed Fireftp 0.90 extension
4. restarted firefox
5. went into tools->options, selected privacy menu option and turned on everything
6. closed firefox...no clear private data confirm dialogue appeared
7. restarted firefox and the clear private data confirm dialogue came up.

Note:  I have numerous extensions installed.  They were installed while running Firefox version 1.0.7:

Adblock 0.5.2.039
Colorzilla 0.8.2
CountDownClock 1.3.1
CuteMenus - Crystal 0.4A1 (disabled, not compatible)
CuteMenus2 (oops, forgot this was here)
DOM Inspector 1.8
Ext2Abc 0.4
FirefoxView 0.31.2
FireFtp 0.90 (Installed after upgrade to 1.5RC2)
Firesomething 1.7.0 (disabled, not compatible)
ForecastFox 0.8.2.4
Highlighter 0.1.1 (disabled, not compatible)
IE Tab 1.0.5
IE View 1.2.7
LinkChecker 0.4.2
MeasureIt 0.3.3
NoScript 1.1.3.3
Nuke Anything 0.2
PDF Download 0.5.1.2
TabBrowser Preferences 1.2.8.7
Talkback 1.5
Web color names 1.0.14 (disabled, not compatible)
Web Developer 0.9.4
Wizz RSS News Reader 1.0.9 (disabled, not compatible)

btw, I'm using Windows XP on a PC.

Comment 61

[Adam Guthrie]

*** Bug 317711 has been marked as a duplicate of this bug. ***

Comment 62

[Norm Hardy]

Attachment: Apple's bug-reporter output.

This bug is solid on my machine.
The attached text is from the report that Apple builds to report crashes to Apple.
It is sort of self explanatory.
Contact me if you need further information.

OS 10.5.1; Intel Duo; Firefox 3.0b2

Comment 63

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.