314819 - Exception in browser.xml when closing the history sidebar (nsITypeAheadFind.setDocShell)

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When closing the history sidebar I get following reproducable exception with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051101 Firefox/1.6a1

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITypeAheadFind.setDocShell]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: onPageHide :: line 455"  data: no]
Source File: chrome://global/content/bindings/browser.xml
Line: 455

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051102 Firefox/1.6a1 ID:2005110217

I see this too.
Only in trunk.

Comment 2

[Ria Klaassen (not reading all bugmail)]

The error appeared for the first time between 1.9a1_2005103113 and 1.9a1_2005103122.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Code fragment where it happens:

<method name="onPageHide">
   
  var tabBrowser = this.getTabBrowser();
  if (!tabBrowser || tabBrowser.mCurrentBrowser == this)
    this.fastFind.setDocShell(this.docShell);
                  ^^^^^^^^^^^

This regression is produced by the check-in of bug 314288.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot reproduce with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051110 Firefox/1.6a1.

Please tell me more detail for the steps.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)

> I cannot reproduce with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> rv:1.9a1) Gecko/20051110 Firefox/1.6a1.

Still visible with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051112 Firefox/1.6a1

To reproduce you only have to open the history sidebar and close it afterwards with CRTL+H. Nothing more to do.

Comment 6

[Ria Klaassen (not reading all bugmail)]

with javascript.options.showInConsole to true.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks, I can reproduce too.
This will fix by bug 315653.

Comment 8

[Peter van der Woude [:Peter6]]

*** Bug 320862 has been marked as a duplicate of this bug. ***

Comment 9

[Steve England [:stevee]]

*** Bug 328710 has been marked as a duplicate of this bug. ***

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

bug 315653 is fixed. this is fixed by it.