Closed Bug 31482 Opened 25 years ago Closed 25 years ago

frameset "ROWS=95,*," nothing comes up

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: jonathan.brickman, Assigned: pollmann)

References

()

Details

(Whiteboard: fix in hand)

When I go to this web page (a major online newspaper in the United Arab Emirates), nothing at all comes up; just a blank white window. This is build #2000031008.
In a build i did today, I get this during and when finished loading. I also see nothing, altho the throbber & progress meter stop. View source brings up the page, it appears to be a framed page. I build at about 6:00p on 3-11-00 on NT sp6. Changing component to layout and confirming bug. Document http://www.khaleejtimes.com/ loaded successfully Document: Done (2.5 secs) FindShortcut: in='http://www.khaleejtimes.com/' out='null' [ensuring channel]: http://www.khaleejtimes.com/ [ensuring channel]: http://www.khaleejtimes.com/ WEBSHELL+ = 19 WEBSHELL+ = 20 Block(td)(1)@022857F0: WARNING: max-element-size:1725,285 desired:7080,255 maxSi ze:1073741824,1073741824 Block(td)(2)@021CF588: WARNING: max-element-size:1725,285 desired:7080,255 maxSi ze:1073741824,1073741824 [ensuring channel]: http://www.cbfs.net/banners/cbfsbanner.gif [ensuring channel]: http://www.khaleejtimes.com/mouseanim.gif [ensuring channel]: http://www.khaleejtimes.com/clickhere.gif Document http://www.khaleejtimes.com/ loaded successfully Document: Done (7.219 secs)
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
24428 has a similar message in the console. reassigning to component owner.
Assignee: cbegle → troy
QA Contact: asadotzler → petersen
A dump of the frame model indicates that the frame cells are ending up with a height of 0. line 01FED264: count=1 state=block,,,[0x402] {0,0,10515,8160} < Frame(frameset)(2)@01FED190 [view=00D14C28] {0,0,10515,8160} < FrameOuter(frame)(0)@01FED28C next=01FED2C8 {0,0,10515,0} < FrameInner(frame)(0)@01FED330 [view=01FE98F8] {0,0,10515,0} < > FrameOuter(frame)(2)@01FED2C8 next=01FED304 {0,0,10515,0} < FrameInner(frame)(2)@01FED364 [view=00D64530] {0,0,10515,0} > 01FED304 BLANK Frame(frameset)(2)@01FED304 {0,0,10515,8160} [state=00000014] > >
Assignee: troy → pollmann
Component: Layout → HTMLFrames
<frameset rows=95,*, frameborder=0 framespacing=0 border=0> My guess is that the extra trailing comma here is confusing the attribute parser in the html frameset frame code. I'll take a look, and aim for M15.
Status: NEW → ASSIGNED
OS: Windows 98 → All
Hardware: PC → All
Summary: Nothing comes up → frameset "ROWS=95,*," nothing comes up
Target Milestone: M15
Yes, this was the problem. I came up with a patch that strips leading and trailing commas from the ROWS or COLS attribute of a <FRAMESET> before trying to use the value. This causes the page to display correctly. Will check in when the tree opens to general checkins.
Whiteboard: fix in hand
*** Bug 25999 has been marked as a duplicate of this bug. ***
Fix checked in. To verify, go to the test case for this url and bug 25999. If you see anything at all, the bug was fixed. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Marking verified fixed in the May 22nd build.
Status: RESOLVED → VERIFIED
Blocks: 51484
Product: Core → Core Graveyard
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.