Closed Bug 314962 Opened 19 years ago Closed 17 years ago

Missing dropdown arrow when you add a Bookmark

Categories

(Firefox :: Bookmarks & History, defect)

1.5.0.x Branch
x86
Windows 98
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

Details

(Keywords: fixed1.8.0.14, verified1.8.1.8)

Attachments

(1 file, 1 obsolete file)

If you select Bookmarks->Book mark this page, the arrow is missing in the dropdown box.

This happens on Win XP also if you turn off native theming.

The bug is that we are applying a style to display part of an image to every image in the dropdown (including the arrow)

We should only be applying it in two specific cases.

Patch coming.
Attached patch Fix for problem (obsolete) — Splinter Review
Only apply the folder icon styles to the two folder icon images.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #201772 - Flags: review?(kevin)
Attachment #201772 - Flags: review?(kevin) → review+
Comment on attachment 201772 [details] [diff] [review]
Fix for problem

I know this is a long shot, but this arrow doesn't appear at all on Win98 (and OS/2) or any system with theming off.
Attachment #201772 - Flags: approval-aviary1.0.8?
Attachment #201772 - Flags: approval-aviary1.0.8? → approval-aviary1.0.8-
Attachment #201772 - Attachment is obsolete: true
Comment on attachment 231635 [details] [diff] [review]
better patch I think

doron, can you tell me which of these patches is more correct? XUL is at:

http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/addBookmark2.xul#108
Attachment #231635 - Flags: review?(doronr)
Attachment #231635 - Flags: review?(doronr) → review+
While researching bug 392693 wuno discovered that getting this in would still help FF on OS/2 at least. I guess for Win98 it would still be nice to have.
Comment on attachment 231635 [details] [diff] [review]
better patch I think

This is no longer relevant on trunk but would be nice polish to fix on branch(es).
Attachment #231635 - Flags: approval1.8.1.7?
Attachment #231635 - Flags: approval1.8.0.14?
Attachment #231635 - Flags: approval1.8.1.7?
Attachment #231635 - Flags: approval1.8.0.14?
Comment on attachment 231635 [details] [diff] [review]
better patch I think

I can't approve these specifically since they are not OS/2 specific. We need general drivers approval.
Attachment #231635 - Flags: approval1.8.1.7?
Attachment #231635 - Flags: approval1.8.0.14?
Comment on attachment 231635 [details] [diff] [review]
better patch I think

approved for 1.8.1.7 and 1.8.0.14, a=dveditz for release-drivers
Attachment #231635 - Flags: approval1.8.1.7?
Attachment #231635 - Flags: approval1.8.1.7+
Attachment #231635 - Flags: approval1.8.0.14?
Attachment #231635 - Flags: approval1.8.0.14+
Fix checked in to both branches.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
I was able to verify this as fixed on 1.8 branch but only OS/2 with
   Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1.8pre)
   Gecko/20071003 BonEcho/2.0.0.8pre
With that version the drop-down arrow is there now. (Leaving keywords and bug status as fixed for Win98 verification.)
Verified fix on 2.0.0.8 
Apologize for the mixup.  My verification was not on win98, but winXP.   Can someone who has a w98 machine please check the fix?

Reverting the keywords field back to fixed1.8.1.8 until a w98 verification is done.
taking, verified fixed 1.8.1.8 using Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.8) Gecko/2007100416 Firefox/2.0.0.8 on win 98
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: