315090 - Convert xpconnect utils/tests to use frozen linkage

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P1)

Description

[Benjamin Smedberg]

In preparation for stopping exporting nonfrozen functions from libxul, I'm
going through the tree and fixing the various tests that currently use the
internal linkage to use frozen linkage. This bug is about the various test
directories under js/src/xpconnect

Comment 1

[Benjamin Smedberg]

Attachment: xpcshell and test with glue, don't build test/component because we can't link with nsVariant

Comment 2

[David Bradley]

Why are the includes needed in the second hunk?

+#include "nsServiceManagerUtils.h"
+#include "nsComponentManagerUtils.h"

Comment 3

[Benjamin Smedberg]

nsIComponentManager.idl onlny includes the Utils file when MOZILLA_INTERNAL_API is defined.

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 201862 [details] [diff] [review]
xpcshell and test with glue, don't build test/component because we can't link with nsVariant

r=shaver, though it's a shame we can't build all the tests -- is there a bug that we can use to track making nsVariant or some equivalent thing available via a frozen API?

Comment 5

[Benjamin Smedberg]

Fixed on trunk.

I tried to expose nsVariant and then ran into problems with needing NSPR (could be solved by not providing nsVariant in the standalone glue): how much do we want to expose that class directly in the glue and how much do we just want to encourage use of the nsIVariant interface?