315305 - Improve nsILocalFile error reporting on Mac

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Simon Fraser [no longer active]]

nsLocalFileOSX ignores a bunch of error codes when mapping OS errors to nsresults. We need to add some so that we can show better error messages.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Patch

Comment 2

[Simon Fraser [no longer active]]

Comment on attachment 202024 [details] [diff] [review]
Patch

This is the wrong file

Comment 3

[Simon Fraser [no longer active]]

Attachment: Patch

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 202025 [details] [diff] [review]
Patch

r=ccarlen

         case fLckdErr:
+        case afpVolLocked:
             outErr = NS_ERROR_FILE_IS_LOCKED;

I wish we had a separate NS_ERROR for a drive being read-only vs. a file. But, even this case is an improvement over what we have

Comment 5

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 202025 [details] [diff] [review]
Patch

This patch is fine and compiles for me on the 1.8 branch.

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 202025 [details] [diff] [review]
Patch

note that the callers of local file may get more specific error codes returned from our interfaces.

Comment 8

[Simon Fraser [no longer active]]

Sorry, no time. Who is XPCOM module owner these days?

Comment 9

[Reed Loden [:reed]]

smfr, do you want somebody else to check this in for you?

Comment 10

[Reed Loden [:reed]]

Checking in xpcom/io/nsLocalFileOSX.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileOSX.cpp,v  <--  nsLocalFileOSX.cpp
new revision: 1.55; previous revision: 1.54
done

Comment 11

[Simon Fraser [no longer active]]

Thanks!