315333 - file datasource failures on osx

Status: RESOLVED WONTFIX

(Core Graveyard :: RDF, defect)

Description

[Shane Caraveo]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051025 Firefox/1.5

1. using an rdf:files datasource with ref="file:///" results in a root directory with no children.  You can also get that with ref="file:///Volumes/", which will show you the primary hard drive on the system, but it has no children.

2. None of the osx code was being used, and in one place, using the unix code, ref="NC:FilesRoot" would just be wrong.  NC:FilesRoot should be equivelent to file:///Volumes/.

The patch (to be attached) fixes all the mac specific code in the file datasource, and adds some osx specific code to handle NC:FilesRoot more correctly.  

You will also see a "break" replaced with a "continue".  That is the  change that fixes #1 above.  There may be a better fix for this elsewhere.

The change in Makefile.in is required for building with the mac specific code.


Reproducible: Always

Steps to Reproduce:
use the template example from http://www.xulplanet.com/tutorials/xultu/treetempl.html

Comment 1

[Shane Caraveo]

Attachment: osx_file_datasource.patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 202053 [details] [diff] [review]
osx_file_datasource.patch

(not my real bugmail!)

Comment 3

[Benjamin Smedberg]

Comment on attachment 202053 [details] [diff] [review]
osx_file_datasource.patch

>Index: rdf/datasource/src/nsFileSystemDataSource.cpp

>+#if defined(XP_MAC) || defined(XP_MACOSX)

XP_MAC is dead, please remove all references of it

>-#if defined(XP_UNIX) || defined(XP_OS2) || defined(XP_WIN)
>+#if defined(XP_UNIX) || defined(XP_OS2) || defined(XP_WIN) || defined(XP_MACOSX)

XP_MACOSX is XP_UNIX, this is not needed.

Also, please have a mac-head review this code, josh or mento.

Comment 4

[Todd Whiteman]

Expired.