Closed
Bug 315347
Opened 19 years ago
Closed 17 years ago
Clean up nsButtonFrameRenderer
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: robarnold)
Details
(Whiteboard: firstbug)
Attachments
(1 file)
6.82 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
The nsButtonFrameRenderer class contains several methods that aren't used (e.g., GetButtonOutlineRect and GetButtonContentRect) as well as many methods that are virtual even though this class has no subclasses.
Reporter | ||
Updated•19 years ago
|
Whiteboard: firstbug
Assignee | ||
Comment 1•17 years ago
|
||
Many methods (ReResolveStyles, GetButtonOuterFocus, etc...) are declared public bu t used only privately. Should these methods be made private or are they part of a public API and happen to be unused?
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•17 years ago
|
||
Attachment #265714 -
Flags: review+
Attachment #265714 -
Flags: review+ → review?(roc)
Reporter | ||
Comment 3•17 years ago
|
||
Comment on attachment 265714 [details] [diff] [review] Removes unused methods and de-virtualizes all the virtual methods of the class thanks
Attachment #265714 -
Flags: superreview+
Attachment #265714 -
Flags: review?(roc)
Attachment #265714 -
Flags: review+
landed on trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•