Closed Bug 315347 Opened 16 years ago Closed 15 years ago

Clean up nsButtonFrameRenderer

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: robarnold)

Details

(Whiteboard: firstbug)

Attachments

(1 file)

The nsButtonFrameRenderer class contains several methods that aren't used (e.g., GetButtonOutlineRect and GetButtonContentRect) as well as many methods that are virtual even though this class has no subclasses.
Whiteboard: firstbug
Many methods (ReResolveStyles, GetButtonOuterFocus, etc...) are declared public bu t used only privately. Should these methods be made private or are they part of a public API and happen to be unused?
Status: NEW → ASSIGNED
Attachment #265714 - Flags: review+ → review?(roc)
Comment on attachment 265714 [details] [diff] [review]
Removes unused methods and de-virtualizes all the virtual methods of the class

thanks
Attachment #265714 - Flags: superreview+
Attachment #265714 - Flags: review?(roc)
Attachment #265714 - Flags: review+
Assignee: nobody → robarnold
Status: ASSIGNED → NEW
landed on trunk
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.