315385 - en-GB Firefox and Thunderbird 1.5 ready for review

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Mark Tyndall]

The en-GB branch is ready for review.

Notable changes from 1.0:

dictionary search-plugin uses Chambers
Amazon s-p has a new tag (see bug 305638)

Comment 1

[Axel Hecht [:Pike]]

dictionary-en-BG should actually be chambers-co-uk or chambers-en-GB.

The rest looks good to me.

Comment 2

[Axel Hecht [:Pike]]

Mark, can we get the renaming of that plugin or should we stick with 
dictionary-en-GB?

Comment 3

[Mark Tyndall]

Real Life is a bit hectic currently and I have very few cycles spare, so if it's not necessary, I'd prefer to leave it as is.  (Sorry, I was reading "should" as being one of "shall, should, may").

I just remembered another change - the Live bookmark feed points directly to the BBC News site (UK edition), not the World edition (via fxfeeds).

Comment 4

[Rafael Ebron (:rebron)]

Need to add Anwsers.com to en-GB.

Comment 5

[Mark Tyndall]

(In reply to comment #4)
> Need to add Anwsers.com to en-GB.

I thought Answers.com replaced Dictionary.com?

We now have a British English dictionary searchplugin

Comment 6

[Rafael Ebron (:rebron)]

We need to add Answers.com as well as it also includes wikipedia and other reference materials.

Comment 7

[Mark Tyndall]

Attachment: Answers.com searchplugin for en-GB [fixed1.8]

adds answers.src and answers.png (from en-US searchplugins) to en-GB; includes it in list.txt as well.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 204440 [details] [diff] [review]
Answers.com searchplugin for en-GB [fixed1.8]

please check in ASAP and comment in the bug once you did, a [fixed1.8] addition to the patch description would be good, too.

Thanks

Comment 9

[Mark Tyndall]

Committed:

RCS file: /l10n/l10n/en-GB/browser/searchplugins/Attic/answers.png,v
done
Checking in answers.png;
/l10n/l10n/en-GB/browser/searchplugins/Attic/answers.png,v  <--  answers.png
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /l10n/l10n/en-GB/browser/searchplugins/Attic/answers.src,v
done
Checking in answers.src;
/l10n/l10n/en-GB/browser/searchplugins/Attic/answers.src,v  <--  answers.src
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in list.txt;
/l10n/l10n/en-GB/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 10

[Mycroft Project (CC)]

Can anyone explain precisely what the delay is?
http://wiki.mozilla.org/L10n:Firefox_1.5_release_candidate_Status just has a cryptic comment...

Comment 11

[Axel Hecht [:Pike]]

In order to be able to link to the upcoming european store based in the UK,
please change the address of the store link to http://store.mozilla-europe.org/en-GB

Thanks

Comment 12

[Mark Tyndall]

Attachment: bookmarks link to store [fixed1.8]

change store link to point to <http://store.mozilla-europe.org/en-GB>
If you want the additional changes that Jay noted (on http://wiki.mozilla.org/L10n:Firefox_1.5_release_candidate_Status), please minus this and I'll get them added ASAP

Comment 13

[Axel Hecht [:Pike]]

I don't think that we need mozilla-europe links, those are not blockers for sure.
We may want to take that and a link to m-e in general as improvements on the 
trunk, but not now. We *really* want this to land ASAP.

Thanks

Comment 14

[Mark Tyndall]

Committed:

Checking in bookmarks.html;
/l10n/l10n/en-GB/browser/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.2.2.6; previous revision: 1.2.2.5
done