315466 - [Website] Browser detection script problems with different Official/Multilingual stable versions numbers.

Status: VERIFIED FIXED

(Camino Graveyard :: Product Site, defect)

Description

[Graeme Porteous]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107 Camino/1.0b1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051107 Camino/1.0b1

Now that Camino is at 1.0b1 and the stable multilingual version of Camino is still only at version 0.8.4 how should the browser detection script handle this? Problem appears on the main page and /start/ page.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Samuel Sidler (old account; do not CC)]

Wevah, can you take care of this? Basically, we need to have two different "stable" versions. I've manually edited the script as of now so you'll have to fix it. :)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

You need to fix "Multi-linguage", too; "Multilingual" or "Multi-language", but not a mish-mash of both :-)

I'd go with "Multilingual" since that's what the graphic to the right uses. 

Comment 3

[Wevah (Nate Weaver)]

You jerk! Don't touch my baby!

I mean, yeah, I'll make it work. ;) I'll just have to get a UA list from somewhere to test with.

Comment 4

[Wevah (Nate Weaver)]

Dangit; one would assume that "accept bug" would automatically reassign to one's self...

-> ME!

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> Dangit; one would assume that "accept bug" would automatically reassign to
> one's self...

I wonder if that's a regression after the recent BMO upgrade?  If not, it seems like a bugzilla bug (or a bit of bad UI), 'cause really, one shouldn't be able to make someone else "accept" a bug....

Comment 6

[Chris Lawson (gone)]

(In reply to comment #5)
> (In reply to comment #4)
> > Dangit; one would assume that "accept bug" would automatically reassign to
> > one's self...
> 
> I wonder if that's a regression after the recent BMO upgrade?  If not, it seems
> like a bugzilla bug (or a bit of bad UI), 'cause really, one shouldn't be able
> to make someone else "accept" a bug....

Bad UI, due to poor wording. "Accept bug" simply accepts the bug for assignment. If you want it assigned to you (I found this out the hard way like Wevah did), you've gotta reassign to yourself.

cl

Comment 7

[Samuel Sidler (old account; do not CC)]

Wevah, since I believe you fixed this, can you resolve it as such?

Comment 8

[Wevah (Nate Weaver)]

Fixed, as far as I'm aware. As per usual, feel free to reopen if this isn't the case.

Comment 9

[Samuel Sidler (old account; do not CC)]

This is still broken on caminobrowser.org/start. I've added a manual, temporary fix for the time being, but the official release link was broken. It's the one using the include file agentdetect_start.inc.php.

Wevah, can you look at this when you get a chance? As I said, I've done a manual fix, but it'd be good if this was dynamic.

Comment 10

[Wevah (Nate Weaver)]

Okay, this should be fixed better now.

I renamed all of the download directories, so they use the exact version number now (e.g., "1.0b1", or "0.8.4" with or without "-MultiLingual"). The old URLs redirect to the new via some mod_rewrite directives. Using the actual version string should make this much easier on us in the future!

Comment 11

[Samuel Sidler (old account; do not CC)]

v.