315566 - choose-classification.html.tmpl incorrect bugzilla tag causes errors

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[marc.fessler]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; InfoPath.1; .NET CLR 2.0.50727)
Build Identifier: Internet Explorer

in choose-classification.html.tmpl, the [e-mail]  tag is a standard html comment tag rather than a template toolkit comment. This causes the <!-- [e-mail] --> to be inserted as the first tag in the html document. In my case it affected some css styles I am using to add a few links to the banner section. Changing the tag to a template toolkit comment solved the problem.

Reproducible: Always

Steps to Reproduce:
1. add some links to the banner, style them with css
2. looks fine on every page
3. go to the select classification section and the link styles are messed up

Actual Results:  
the link text is miniscule

Expected Results:  
link text should have looked the same as it does on every other page in bugzilla

Comment 1

[Marc Schumann [:Wurblzap]]

Good catch!

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 3

[Frédéric Buclin]

Comment on attachment 202257 [details] [diff] [review]
Patch

r=LpSolit

Comment 4

[Frédéric Buclin]

2.20 is also affected (2.18 is not)

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Low-risk polish.

Comment 6

[Marc Schumann [:Wurblzap]]

Tip:
Checking in template/en/default/global/choose-classification.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-classification.html.tmpl,v  <--  choose-classification.html.tmpl
new revision: 1.6; previous revision: 1.5
done

2.20 Branch:
Checking in template/en/default/global/choose-classification.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-classification.html.tmpl,v  <--  choose-classification.html.tmpl
new revision: 1.4.4.1; previous revision: 1.4
done