If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

add anchors to attachments section

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Creating/Changing Bugs
--
enhancement
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

2.20
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
i can provide a url that links to comment 0, or comment 1, but i can't link to the flags section of a bug.

please create a named section <a name="flags" href="#flags">Flags</a>:

for bonus points, anchors to individual flags. #f-...
(Assignee)

Updated

12 years ago
Severity: minor → enhancement
(Assignee)

Comment 1

12 years ago
Created attachment 203930 [details] [diff] [review]
draft
Assignee: create-and-change → timeless
Status: UNCONFIRMED → ASSIGNED
Attachment #203930 - Flags: review?(kiko)

Comment 2

12 years ago
Comment on attachment 203930 [details] [diff] [review]
draft

This is cool!

Probably the reporter talked about bug-flags. Timeless's patch implements attachment-flags.

Both of them would be cool to have, but this works for now.

Not sure if 'a' is the best prefix, but can be fixed upon checkin if we have a better name for it.

The patch applies cleanly.
Attachment #203930 - Flags: review?(kiko) → review+

Comment 3

12 years ago
In case you approve/checkin/resolve, please file another bug for anchors related to bug-flags (and update this summary accordingly)
Flags: approval?
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.24
Flags: approval? → approval+

Comment 4

12 years ago
I've opened up bug 340530 for the part that didn't get implemented in this patch.

Commited on trunk:

Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.29; previous revision: 1.28
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

12 years ago
i should probably note a few items.
1. if anyone ever references this anchors in urls and tries to involve an attachment that follows a private attachment, if that private attachment looses its private status, or if the link is viewed by someone who can see private attachments, then the anchor will be bad (permanently too).

2. re comment 2, probably the reporter, hrm, that's me, i'm reporter, patch author, and clearly sleepy hacker. how ironic.
Summary: add anchors to flag section → add anchors to attachments section

Comment 6

12 years ago
Created attachment 224580 [details] [diff] [review]
Patch for fixing the private thing, v1
Attachment #224580 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #224580 - Flags: review? → review+

Comment 7

12 years ago
Comment on attachment 224580 [details] [diff] [review]
Patch for fixing the private thing, v1

Follow-up patch for bug 315590: fix scenario where we have private attachments, and make the numbering behaviour consistent with the way we currently treat private bug comments; patch by Vlad Dascalu <vladd@bugzilla.org>, r=timeless; a=myk on the bug.

Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.30; previous revision: 1.29
done
You need to log in before you can comment on or make changes to this bug.