315601 - embed-base needs to be compiled twice, once for dependent usage and once for standalone usage

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: MFC Embed, defect)

Description

[Benjamin Smedberg]

This has been in my tree for a while, but I didn't realize that is was needed to not break MFCEmbed with bug 305949. MFCEmbed, which uses the standalone glue, was linking against the dllimported versions of NS_InitXPCOM3 etc, which only happened to work previously because the XPCOM glue declared these functions as dllexport (which was totally wrong). I'm going to check this in and get ex-post-facto review because a couple of the tboxen are red (only the ones which build tests, or this would have shown up sooner).

Comment 1

[Benjamin Smedberg]

Attachment: Build two versions of the embed_base lib

Comment 2

[Darin Fisher]

Comment on attachment 202302 [details] [diff] [review]
Build two versions of the embed_base lib

>Index: embedding/base/objs.mk

>+# The Original Code is the Mozilla browser.
>+#
>+# The Initial Developer of the Original Code is
>+# Christopher Blizzard.  Portions created by Christopher Blizzard Copyright (C) 1999, Christopher Blizzard.  All Rights Reserved.
>+# Portions created by the Initial Developer are Copyright (C) 2001
>+# the Initial Developer. All Rights Reserved.

Is this really the proper License header for this file?  ditto for the other new files.


r=darin

Comment 3

[Benjamin Smedberg]

Yes, they are copy-pasted files so the original license applies... it's kinda weird, but that's what I'm told we're supposed to do.