Shift modifier used with command-return in location bar or search field fails to open result in foreground

VERIFIED FIXED in Camino1.5

Status

VERIFIED FIXED
14 years ago
13 years ago

People

(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)

Tracking

({fixed1.8})

unspecified
Camino1.5
PowerPC
macOS
fixed1.8

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

14 years ago
Holding the shift key while clicking on a link forces the opposite behaviour of browser.tabs.loadInBackground. However, holding shift while typing cmd-return in either the location bar or the search field fails to switch the behaviour.

Filed as a new bug so as to avoid re-opening bug 201795, which isn't really the same issue (but is where this issue was raised).

This should be pretty easy to fix. I might be able to have a patch ready by the end of the week.
(Assignee)

Comment 1

14 years ago
Also slightly shortens an earlier bit of appendtabs/replacetabs logic when dragging bookmark folders to open tab bar. If that part's no good, let me know and I'll take it out. It has nothing to do with this bug.

cl
(Assignee)

Comment 2

14 years ago
Accepting.

cl
Status: NEW → ASSIGNED
(Assignee)

Comment 3

14 years ago
Fixes a problem where if browser.tabs.loadInBackground was FALSE, it wouldn't override. Also dispenses with trying to change the unrelated code; Wevah advised against it (and to be honest, I don't really disagree with him.)

Asking for r from Simon.

cl
Attachment #202859 - Attachment is obsolete: true
Attachment #202862 - Flags: review?(sfraser_bugs)

Comment 4

14 years ago
Comment on attachment 202862 [details] [diff] [review]
updated per Wevah's suggestions and bugfix

>Index: BrowserWindowController.mm
>===================================================================

>+  BOOL loadInBG  = aShiftIsDown ? ![[PreferenceManager sharedInstance] getBooleanPref:"browser.tabs.loadInBackground" withSuccess:NULL] :
>+                                   [[PreferenceManager sharedInstance] getBooleanPref:"browser.tabs.loadInBackground" withSuccess:NULL];

This is confusing. Read the pref value, then negate it.
Attachment #202862 - Flags: review?(sfraser_bugs) → review-
(Assignee)

Comment 5

14 years ago
As requested, now reads pref, then negates.

cl
Attachment #202862 - Attachment is obsolete: true
Attachment #202867 - Flags: review?(sfraser_bugs)

Updated

14 years ago
Attachment #202867 - Flags: review?(sfraser_bugs) → review+
(Assignee)

Comment 6

14 years ago
Comment on attachment 202867 [details] [diff] [review]
Updated per Simon's suggestion

sr=pink?
Attachment #202867 - Flags: superreview?(mikepinkerton)

Updated

14 years ago
Attachment #202867 - Flags: superreview?(mikepinkerton) → superreview+

Comment 7

14 years ago
I landed the patch. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.