315866 - "New window" item no longer in dock menu

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Mike Pinkerton (not reading bugmail)]

The "new window" menu item in the dock menu has gone missing. Reward for its return. If found, please post patch here in this bug.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I can't bring you back "new window" (or his buddy, "open in tabs"), but I do have a regression window for you:

http://tinyurl.com/7l3qg

(Why is it things always break in a window where we're missing a build).

You, Mark, and Simon made Camino checkins in that window, but none of them touched MainMenu.nib...?

Comment 2

[Jasper]

I very much doubt it has to do with the nib file since the item is in place there and is hookedup correctlt. My guess is some change in code caused the removal.

A lot of changes where made in the week of 2005-07-30 till 2005-08-04 so I'm assuming something in the code that enables that menu tems was broken in that time.

Comment 3

[Mark Mentovai]

Attachment: New MainMenu.nib/keyedobjects.nib

This was almost certainly fallout from Simon's NSMenu reworking.  I found the dock menu's mItemBeforeCustomItems was not connected to the separator's NSMenuItem, and in fact, it was not connected to anything at all.  In this nib, the connection is made.

There's some additional code cleanup that can be done here: there are a few methods and constants that might now be dead and removable.

Comment 4

[Mark Mentovai]

P.S. What's the reward I've heard talk about?

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 202544 [details]
New MainMenu.nib/keyedobjects.nib

the journey is the reward.

*ducks*

r=pink, though i didn't try it.

Comment 6

[Mark Mentovai]

Fixed, trunk and branch.

Comment 7

[Simon Fraser [no longer active]]

Thanks!

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FWIW, Mark's fix didn't bring back "Open it tabs" for the Dock menu (which appeared at the bottom of the list of Dock menu bookmarks after a blank line).