Closed Bug 315877 Opened 19 years ago Closed 19 years ago

Inconsistent terminology: Send Link. vs Email Page Location

Categories

(Camino Graveyard :: General, defect, P3)

PowerPC
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.0

People

(Reporter: sfraser_bugs, Assigned: alqahira)

Details

(Keywords: fixed1.8, polish)

Attachments

(2 files, 1 obsolete file)

From feedback mail:

The button is called "Send Link", but the menu item is called "Email Page Location".
Flags: camino1.0?
Priority: -- → P3
Target Milestone: --- → Camino1.0
The context menu also calls it "Send This Link...", which is appropriate because you're clicking on a link.  

Email Page Location makes more sense for the menu item and the button name, since they're not links per se.

See also bug 295774 for inconsistencies in Clear/Empty Cache and Clear History/Visited Pages.
And "E-mail this link" would make more sense for the contextual menu item, for the sake of consistency.

cl
So we want

Toolbar Sheet: Email Page Location
Toolbar*: Email Location
File Menu: Email Page Location (no change)
Context Menu: Email This Link…

(* the other long button titles, View Page Source and Manage Bookmarks, shorten when the button is displayed in the toolbar)

Sounds good to me.
Keywords: polish
Oh, do we want to be really pedantic (and proper) and hyphenate e-mail? The unhyphenated version makes me cringe, and I'm not alone:

http://www.theslot.com/email.html

Assigning to Smokey, too.

cl
Assignee: mikepinkerton → alqahira
Safari and Mail use "Email".

I've got a question, though.  The toolbar stuff is defined here: 
http://lxr.mozilla.org/mozilla/source/camino/src/browser/BrowserWindowController.mm#1257

I *think* that means these are just localizable string changes, but the bit in the code looks different than all the other localizable string changes, i.e., this bit of code includes both the "string title" and the default string text, and most localizable string-related code just includes the former.  Are we going to have to change BrowserWindowController.mm, too, or is it really just a localizable.strings change?

(The CM part is a nib change, and I've got that ready.)
(In reply to comment #5)
> Safari and Mail use "Email".

Safari and Mail are wrong.

cl
(In reply to comment #6)
> (In reply to comment #5)
> > Safari and Mail use "Email".
> 
> Safari and Mail are wrong.

Nah, "email" is a word now.
To answer my own question in comment 5, the wierd format of the localizable string references in BrowserWindowController.mm shouldn't be a problem (I changed the strings file and tested), but we'll still need to patch BrowserWindowController.mm if we want a short form and long form of the new label, because the current code uses the same localizable string for both labels.
Chris, could you build with this to verify that it works?  Since I'm not touching "real" code it should be just like a real strings change, but better safe than sorry.
Localizable.strings updated for *this bug only*; it doesn't have any of the changes for the interdependent clear/empty/remove warnings bugs.  

If this bug lands first, we can use this strings file; if not, I already have these changes made to the file that contains the in-progress changes for those bugs.
Updated BrowserWindow.nib that contains the context menu change
Comment on attachment 202783 [details]
Localizable.strings updated for this bug ONLY

This is obsolete now; there are newer strings in bug 316675 (but they don't have these changes).

When I know the patch works :-) I'll upload new strings--and hopefully bug 316675 will have already landed so we won't have so many strings files floating around....
Attachment #202783 - Attachment is obsolete: true
Attachment #202783 - Attachment mime type: text/plain; charset=UTF-16 → text/plain; charset=utf-16
This is blocking beta 2, per discussions.
Flags: camino1.0? → camino1.0+
Fixed, branch and trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: