315933 - The slash in empty element tags in XML are red in view source

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Simon Pieters [:zcorpan]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051109 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051109 Firefox/1.6a1

View source of the document data:application/xml,<foo/> shows the slash in red, as if it were a syntax error. It is not a syntax error in XML, therefore the slash should not be red. (It is a syntax error in text/html documents though; please leave it red for view-source:data:text/html,<foo/> !)

Reproducible: Always

Steps to Reproduce:
1. Open view-source:data:application/xml,<foo/>
2.
3.

Actual Results:  
The slash is red.

Expected Results:  
The slash should be the same color as the angle brackets (black).

Comment 1

[Josh Birnbaum]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051110 Firefox/1.6a1

->HTML: Parser (syntax highlighting bugs seem to be spread around, so I apologize in advance for guessing where to route this...)

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

D'oh! I realized this yesterday but forgot to file the bug. I'll fix this soon.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Potential patch

I haven't compiled or tested this yet, but I think it should do the right thing.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: The simple route

Getting the error reporting right in all cases in view-source is more work than is worth it (and that's what our XML parser is for, anyway), so simply don't bother coloring trailing /s in XML.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 202703 [details] [diff] [review]
The simple route

r+sr=jst

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 7

[jag (Peter Annema)]

Why not the simpler

+            if (kQuote == aChar || kApostrophe == aChar ||
+                (kForwardSlash == aChar && !(aFlag & NS_IPARSER_FLAG_XML))) {
               mInError = PR_TRUE;

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

We still need to fall through to the ConsumeInvalidAttribute below, which I don't think your patch allows.

Comment 9

[jag (Peter Annema)]

Ah, of course. /me needs to get that tunnel vision fixed

Comment 10

[Simon Pieters [:zcorpan]]

The slash is still red in View Selection Source.

Steps to reproduce:
1. Open data:application/xml,<p xmlns="http://www.w3.org/1999/xhtml">foo<br/>bar</p>
2. Select All
3. View Selection Source

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I believe that was intentional since the slash is in fact an error.

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

That's a different bug. The view selection source code needs to tell the parser that it's parsing XML. This bug is FIXED.

Comment 13

[Daniel Veditz [:dveditz]]

Take on branches if we take bug 314980

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to comment #13)
> Take on branches if we take bug 314980

Dan, the branch patch in bug 314980 includes the patch for this bug.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 202703 [details] [diff] [review]
The simple route

approved for 1.8/1.8.0 branches, a=dveditz for drivers

Comment 16

[Blake Kaplan (:mrbkap) (inactive)]

This was fixed on the 1.8 branches.

Comment 17

[alice nodelman [:alice] [:anode]]

Verified trailing '/' in view-source:data:application/xml,<foo/> is not red for 2.0.0.2pre and 1.5.0.10pre.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/2007011103 BonEcho/2.0.0.2pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.10pre) Gecko/20070111 Firefox/1.5.0.10pre

Comment 18

[Simon Pieters [:zcorpan]]

Hmm. Now that <br/> and <math/> are valid in HTML5 and work for integrating an HTML5 parser in Gecko has started, maybe this bug should be reversed or at least the slash should not be red when it's the trailing slash on a void HTML element or an SVG or MathML element?

Comment 19

[Henri Sivonen (:hsivonen)]

The slash redness should probably be relaxed as part of bug 482921.