315935 - Image is not blocked when right click adblock or putting url into the adblock field

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Arnold miles Ridley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5

It is impoosible to be able to block an image as it recognises that you want it to be blocked, but it doesn't disappear, adblock was enabled. I'm using windows xp sp2 with the newest version of firfox 1.5 rc1. Adblock is latest version- 0.5.2.039. Also i cannot block flash. Nothing can be blocked if i try with url or right click block image or block iframe. Adblock extension does not filter the image.

Reproducible: Always

Steps to Reproduce:
1. Go to a website with known adverts eg. www.onrpg.com or www.ebaumsworld.com
2. Right click on image or flash object
3. Select block image

Actual Results:  
adblock recognises the link to be block- appears on blocked link list, but nothing happens to the image- it stays there

Expected Results:  
the image should disappear and be blocked on every website i go onto that it occurs to be on aswell.

theme i was using was black japan, but it occurs with normal theme too.

about:buildconfig

Build platform
target
i586-pc-msvc

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	12.00.8804 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	12.00.8804 	-TP -nologo -W3 -Gy -Fd$(PDBFILE)

Configure arguments
--enable-application=browser --enable-update-channel=release --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-official-branding --enable-svg --enable-canvas --enable-update-packaging

Comment 1

[Robert Strong (they/them - no direct email)]

I'm not sure what exactly changed in the core since adblock 0.5.2.039 was released around 16 months ago but a lot has changed since then. What ever did change is not an Extension Manager problem - the Extension Manager manages extension install, uniinstall, upgrade, update, etc. and it is not manage the interaction of an extension with the application, interfaces, etc.

You may want to consider trying out adblock plus which was created from adblock and has had active further development. I believe the author of adblock plus has also updated the original adblock so it is compatible with 1.4 which may work with 1,5 but that was a while ago so it may no longer work.
http://bene.sitesled.com/adblock.htm

What ever the case, the original adblock has at least a couple of issues that need to be addressed with the extension itself to make it compatible with 1.5