If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Software Update progress bar updates in 300k chunks, making it look stalled for dialup users

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Toolkit
Application Update
RESOLVED FIXED
12 years ago
8 years ago

People

(Reporter: marcia, Assigned: florian)

Tracking

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
Picked up as a comment from Asa's blog:

"One thing i did notice is the update shows progress in 64kb blocks. This is a minor nuisance, because on dialup it looks like it has stalled."

So it looks as if the software update experience for dialup users could be improved so that it doesn't look like it has stalled.
OS: MacOS X → All
Hardware: Macintosh → All

Updated

12 years ago
Summary: Software Update Dialup experience is not optimal → Software Update progress bar updates in 64k chunks, making it look stalled for dialup users
Product: Firefox → Toolkit
(Assignee)

Comment 1

8 years ago
Since bug 352853 was fixed, the size of the chunks is 300kB.

With the slow DSL connection I have here, it means that the progress b
Version: 1.8.0 Branch → Trunk
(Assignee)

Comment 2

8 years ago
(In reply to comment #1)
(sorry, I hit tab and space, it sent the comment while I was typing...)

> With the slow DSL connection I have here, it means that the progress b
ar is updated only every 10 seconds or so.
(Assignee)

Comment 3

8 years ago
Created attachment 383105 [details] [diff] [review]
Patch v1

This patch makes nsIncrementalDownload call onProgress when new data is available instead of when a chunk is completely received. It will notify of progress at most twice a second, which seems a reasonable frequency to update the progressbar in the UI.

For users with very fast connections, it may reduce the total number of progress notifications, as previously if several chunks were received at once, onProgress was called several times in a row.
Assignee: nobody → florian
Attachment #383105 - Flags: review?(cbiesinger)
Attachment #383105 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ef294ff168be
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Summary: Software Update progress bar updates in 64k chunks, making it look stalled for dialup users → Software Update progress bar updates in 300k chunks, making it look stalled for dialup users
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.