316139 - Option that forces link to open in the same tab, or a new tab fails sometimes

Status: VERIFIED DUPLICATE of bug 314721

(Firefox :: Tabbed Browser, defect)

Description

[roberjruiz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051107 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051107 Firefox/1.5

- Under tools/options, check on "Force link that open new windows to open in:". Choose any of the two possible options. Bug happens with both of them
- I detected some cases where it opens a new window instead of using the same one, or opening a new tab. Both of them were .php links, although I am not sure if it happens with all .php links


Reproducible: Always

Steps to Reproduce:
1. Under tools options, check on "Force link that open new windows to open in:". Choose any of the two possible options. Bug happens with both of them.
2. Go to http://www.ogame.co.uk
3. Login on the game. I created a test account, so that you may login.
   Select "11. Universe" in the "Choose Universe" combo 
   User: dummy
   Password: testtest
4. Once logged on, click on notes. 

Actual Results:  
It will open a new window

Expected Results:  
It should open the link in a new tab, or in the same tab, depending on the option choosen

- I detected the bug in firefox 1.5rc1 and 1.5rc2. It worked OK in 1.5b2

- All links that showed the problem were .php

Comment 1

[Reed Loden [:reed]]

<a href='#' onclick='fenster("notizen.php?session=f79363d68f4f", "Bericht");' accesskey="n">Notes</a>
...
<script language="JavaScript">
function fenster(target_url,win_name) {
  var new_win = window.open(target_url,win_name,'resizable=yes,scrollbars=yes,menubar=no,toolbar=no,width=550,height=280,top=0,left=0');
  new_win.focus();
}
</script>

Bug 313300 purposely changed the way the window.open() function is handled.

If you wish to set your settings back to the old way, change browser.link.open_newwindow.restriction from 2 (don't divert window.open with features) to 0 (divert all window.open calls to tabs).

Comment 2

[Jesse Ruderman]

*** This bug has been marked as a duplicate of 314721 ***