Closed
Bug 316258
Opened 19 years ago
Closed 19 years ago
Document new tab feature (Reorder / Rearrange / Move browser tabs)
Categories
(SeaMonkey :: Help Documentation, defect)
SeaMonkey
Help Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey1.0beta
People
(Reporter: stefanh, Assigned: prometeo.bugs)
References
Details
(Keywords: fixed1.8)
Attachments
(1 file, 2 obsolete files)
7.72 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-seamonkey1.0+
|
Details | Diff | Splinter Review |
We should document the new tab feature. It will fit well into the existing documentation - I can imagine a new subheading would be nice. There are also a few new shortcuts.
Reporter | ||
Comment 1•19 years ago
|
||
Giacomo, if you want to take this - just go ahead. I won't have the time for some days... If the patch in bug 105885 goes into the branch we'll need this on branch as well.
Assignee | ||
Comment 2•19 years ago
|
||
(In reply to comment #1) > Giacomo, if you want to take this - just go ahead. I won't have the time for > some days... If the patch in bug 105885 goes into the branch we'll need this on > branch as well. I still have to see the feature in action. IS there any place I can look to for inspiration? :)
Reporter | ||
Comment 3•19 years ago
|
||
(In reply to comment #2) > (In reply to comment #1) > > Giacomo, if you want to take this - just go ahead. I won't have the time for > > some days... If the patch in bug 105885 goes into the branch we'll need this on > > branch as well. > > I still have to see the feature in action. IS there any place I can look to for > inspiration? :) > Well, bug 105885 was fixed 2005-12-05, so you could grab a nightly build :)
Assignee | ||
Comment 4•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Attachment #205392 -
Flags: review?(iann_bugzilla)
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 205392 [details] [diff] [review] Lame rip-off of FX help, including shortcuts. A Mac-head will need to verify them. No changes to rdf files seems needed. >Index: extensions/help/resources/locale/en-US/customize_help.xhtml >=================================================================== ... ... >+ window, simply drag it there using your mouse. While you are dragging the >+ tab, &brandShortName; displays a small down arrow to show where the tab will >+ be moved We don't display the arrow on mac Classic... As for the changes in extensions/help/resources/locale/en-US/shortcuts-navigator.xhtml, mac uses "Cmd" instead of "Ctrl". I'll comment more in a while, so no need to attach anything new yet :)
Reporter | ||
Comment 6•19 years ago
|
||
(In reply to comment #4) > No changes to rdf files seems needed. Actually, you'll have to change that - just look in the contents pane ;) (In reply to comment #5) > (From update of attachment 205392 [details] [diff] [review] [edit]) > >Index: extensions/help/resources/locale/en-US/customize_help.xhtml > >=================================================================== > ... > ... > >+ window, simply drag it there using your mouse. While you are dragging the > >+ tab, &brandShortName; displays a small down arrow to show where the tab will > >+ be moved > > We don't display the arrow on mac Classic... Hmm, since we don't display any arrow in mac classic and it seems to me that the arrow is a bit mis-placed in Modern (at least on mac) - it appears once between the "from" tab and the adjoining tab, ie it doesn't follow the movement as I would expect from the text - I suggest just leaving out that part. Since we're actually doing this with css in the themes, I can imagine that there might be third-party themes that doesn't diplay any arrow. Anyway, I'll leave the decision to Ian. > > As for the changes in > extensions/help/resources/locale/en-US/shortcuts-navigator.xhtml, mac uses > "Cmd" instead of "Ctrl". > Just replace "Ctrl" with "Cmd" for mac and you'll be fine.
Reporter | ||
Updated•19 years ago
|
Assignee: help.viewer → giacomo.magnini
Reporter | ||
Updated•19 years ago
|
Component: Help Viewer → Help
Product: Documentation → Mozilla Application Suite
Target Milestone: --- → seamonkey1.0beta
(In reply to comment #6) > (In reply to comment #4) > > > No changes to rdf files seems needed. > > Actually, you'll have to change that - just look in the contents pane ;) Yes, you will have to add an entry under Tabbed Browsing in Customizing SeaMonkey. Also something needs to go into index under Tabbed Browsing. Possibly a few other places to look at too. > > > (In reply to comment #5) > > (From update of attachment 205392 [details] [diff] [review] [edit] [edit]) > > >Index: extensions/help/resources/locale/en-US/customize_help.xhtml > > >=================================================================== > > ... > > ... > > >+ window, simply drag it there using your mouse. While you are dragging the > > >+ tab, &brandShortName; displays a small down arrow to show where the tab will > > >+ be moved > > > > We don't display the arrow on mac Classic... > > Hmm, since we don't display any arrow in mac classic and it seems to me that > the arrow is a bit mis-placed in Modern (at least on mac) - it appears once > between the "from" tab and the adjoining tab, ie it doesn't follow the movement > as I would expect from the text - I suggest just leaving out that part. Since > we're actually doing this with css in the themes, I can imagine that there > might be third-party themes that doesn't diplay any arrow. Anyway, I'll leave > the decision to Ian. Are there any other places that display things differently under different themes and are mentioned in help? > > > > As for the changes in > > extensions/help/resources/locale/en-US/shortcuts-navigator.xhtml, mac uses > > "Cmd" instead of "Ctrl". > > > Just replace "Ctrl" with "Cmd" for mac and you'll be fine. > Agreed.
Attachment #205392 -
Flags: review?(iann_bugzilla) → review-
Assignee | ||
Comment 8•19 years ago
|
||
- Added entries to help-toc and help-index1 - Changed "small down arrow" to "indicator" (like FX) - Changed Ctrl to Cmd for Mac shortcuts
Attachment #205392 -
Attachment is obsolete: true
Attachment #205537 -
Flags: review?(iann_bugzilla)
Reporter | ||
Comment 9•19 years ago
|
||
> Are there any other places that display things differently under different
> themes and are mentioned in help?
I can't think of any, but I haven't really looked for it. Note that on mac classic we don't display anything.
Comment 10•19 years ago
|
||
Comment on attachment 205537 [details] [diff] [review] Updated patch. Is it worth mentioning the keyboard shortcuts don't work when a text box has focus?
Attachment #205537 -
Flags: review?(iann_bugzilla)
Attachment #205537 -
Flags: review+
Attachment #205537 -
Flags: approval-seamonkey1.0+
Assignee | ||
Comment 11•19 years ago
|
||
Reporter | ||
Comment 12•19 years ago
|
||
There might be some last-minute changes of the shortcuts, but I suppose that could go in bug 320161... :/
Comment 13•19 years ago
|
||
Comment on attachment 205809 [details] [diff] [review] Like so? (Checked in to trunk/branch 1.8 & 1.8.0) yes
Attachment #205809 -
Flags: review+
Attachment #205809 -
Flags: approval-seamonkey1.0+
Attachment #205537 -
Attachment is obsolete: true
Reporter | ||
Updated•19 years ago
|
Attachment #205809 -
Attachment description: Like so? → Like so? (Checked in to trunk/branch)
Reporter | ||
Comment 14•19 years ago
|
||
Checked in (trunk/branch) by Standard8. Some minutes left to the freeze, puh.
Comment 15•19 years ago
|
||
Comment on attachment 205809 [details] [diff] [review] Like so? (Checked in to trunk/branch 1.8 & 1.8.0) Checking in (branch 1.8.0) customize_help.xhtml; new revision: 1.45.16.1; previous revision: 1.45 shortcuts-navigator.xhtml; new revision: 1.10.6.2.2.1; previous revision: 1.10.6.2 help-index1.rdf; new revision: 1.44.8.1.2.1; previous revision: 1.44.8.1 help-toc.rdf; new revision: 1.78.4.2.4.1; previous revision: 1.78.4.2 done
Attachment #205809 -
Attachment description: Like so? (Checked in to trunk/branch) → Like so? (Checked in to trunk/branch 1.8 & 1.8.0)
You need to log in
before you can comment on or make changes to this bug.
Description
•