316289 - cvsview2.cgi problems due to new cvs version

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect)

Description

[Robert Kaiser]

Newer CVS versions add commitid identifiers into their RCS files, and cvsview2.cgi chokes on those, just displaying error messages.

Example of what I see on a directory:
-------
Unexpected parsing error in RCS file .
Expected token: date, but saw: 26904377525b4567
-------

Example of a single file:
-------
Unexpected parsing error in RCS file /usr/local/cvsroot/com/php/include/util/com_database.php-class,v.
Expected token: date, but saw: 5c7943663c364567
-------

I'm seeing this on a private bonsai installation combined with
Concurrent Versions System (CVS) 1.12.12 (client/server)

If someone wants to check this stuff in detail, sp. writing a patch for it, I can give some insight like the URL where I'm seeing this, maybe the RCS file for that file above privately, I just don't want to link this installation to the wide public.

Comment 1

[Robert Kaiser]

cvslog.cgi shows the same error, cvsblame.cgi displays a "500 Server Error", I guess the same problem is hidden behind it.

Comment 2

[timeless]

if you could upload a random ,v file from 1.12 with a few records, that'd be helpful (create it just for this purpose...)

Comment 3

[Robert Kaiser]

Attachment: robots.txt,v - this has been created with older CVS and updated with 1.12.12

OK, I'm attaching two very small example ,v files here. Both are robots.txt files with the same content, so they should be easy to view :)
This first one has been created with an older CVS version and now I've done an empty forced checkin with the new version that adds this "commitid".
Everyone who upgrades CVS some time will end up with such a mixture...

Comment 4

[Robert Kaiser]

Attachment: robots2.txt,v - this has been created and updated with CVS 1.12.12

This second file (robots2.txt,v) has been created and updated with the newer CVS version.
(Note that it was not part of the initial import of the dir but added later, that why the 1.1.1.1 stuff might be missing...)

Comment 5

[Robert Kaiser]

just as a side note, the second file is from a different repository as well, if you might spot further unrelated inconsistencies between the files :)

Comment 6

[timeless]

Attachment: handle commitid

Comment 7

[Robert Kaiser]

Comment on attachment 202960 [details] [diff] [review]
handle commitid

thanks, this works like a charm on my installation :)

Comment 8

[timeless]

Comment on attachment 202960 [details] [diff] [review]
handle commitid

mozilla/webtools/bonsai/cvsblame.pl 	1.16