If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Whitespace removal and some small cruft

RESOLVED FIXED

Status

()

Firefox
General
--
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Hendrik Maryns, Assigned: Hendrik Maryns)

Tracking

({fixed1.8.1})

Trunk
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

12 years ago
While translating the FF and TB files I encountered some irregularities on how the files are structured.  I have made some patches about this.  Mainly, they remove unnecassary whitespace, introduce newlines at end of files, correct some comments, and reorder some lines in particular files.

No harm is done if they are applied, no harm is done if they aren’t, either.
(Assignee)

Comment 1

12 years ago
Created attachment 202915 [details] [diff] [review]
browser (Help docs) [checked in]

The browser component.
Assignee: nobody → hendrik.maryns
Status: NEW → ASSIGNED
(Assignee)

Comment 2

12 years ago
Created attachment 202916 [details] [diff] [review]
mail [checked in]

Though this is not firefox, I add it here to group these similar patches.
(Assignee)

Comment 3

12 years ago
Created attachment 202917 [details] [diff] [review]
security [checked in]

In the security branch
(Assignee)

Comment 4

12 years ago
Created attachment 202918 [details] [diff] [review]
toolkit [checked in]

The toolkit part.
(Assignee)

Comment 5

12 years ago
As this bug seems to get some attention, I just wanted to add that this are things I stumbled upon for no particular reason, but thought it a waste to do nothing with the changes I made locally, so there you go.
(Assignee)

Updated

12 years ago
Attachment #202915 - Flags: review?(steffen.wilberg)
(Assignee)

Updated

12 years ago
Attachment #202916 - Flags: review?(benjamin)
(Assignee)

Updated

12 years ago
Attachment #202917 - Flags: review?(bugzilla)
(Assignee)

Updated

12 years ago
Attachment #202917 - Flags: review?(bugzilla) → review?(wtchang)
(Assignee)

Updated

12 years ago
Attachment #202918 - Flags: review?(vladimir)

Comment 6

12 years ago
Comment on attachment 202917 [details] [diff] [review]
security [checked in]

r=wtc.

All the changes look fine.  Since Kai is the owner
of mozilla/security/manager, I asked him to do the
official review.
Attachment #202917 - Flags: review?(wtchang) → review?(kengert)

Updated

12 years ago
Attachment #202915 - Attachment description: browser → browser (Help docs)
Attachment #202915 - Flags: review?(steffen.wilberg) → review+
(Assignee)

Updated

12 years ago
Whiteboard: checkin needed

Comment 7

12 years ago
Comment on attachment 202915 [details] [diff] [review]
browser (Help docs) [checked in]

Checking in mozilla/browser/locales/en-US/chrome/help/customization.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/customization.xhtml,v  <--  customization.xhtml
new revision: 1.21; previous revision: 1.20
done
Checking in mozilla/browser/locales/en-US/chrome/help/download_manager.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/download_manager.xhtml,v  <--  download_manager.xhtml
new revision: 1.21; previous revision: 1.20
done
Attachment #202915 - Attachment description: browser (Help docs) → browser (Help docs) [checked in]

Updated

12 years ago
OS: Windows XP → All
Hardware: PC → All
Whiteboard: checkin needed

Updated

12 years ago
Attachment #202917 - Flags: review?(kengert) → review+
(Assignee)

Updated

12 years ago
Whiteboard: checkin needed [security]

Comment 8

12 years ago
Comment on attachment 202916 [details] [diff] [review]
mail [checked in]

I'm glad for the "no newline at end of file" fixes, I don't think the random whitespace changes are useful.
Attachment #202916 - Flags: review?(benjamin) → review+

Updated

12 years ago
Attachment #202918 - Flags: review?(vladimir) → review+
mozilla/toolkit/locales/en-US/chrome/global/config.dtd
new revision: 1.4; previous revision: 1.3
mozilla/toolkit/locales/en-US/chrome/global/console.properties
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/chrome/global/xpinstall/xpinstall.properties
new revision: 1.7; previous revision: 1.6
mozilla/toolkit/locales/en-US/chrome/global-platform/mac/intl.properties
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/chrome/global-platform/unix/intl.properties
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/chrome/global-platform/win/intl.properties
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd
new revision: 1.4; previous revision: 1.3
mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
new revision: 1.10; previous revision: 1.9
mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/update.dtd
new revision: 1.5; previous revision: 1.4
mozilla/toolkit/locales/en-US/chrome/mozapps/plugins/plugins.dtd
new revision: 1.4; previous revision: 1.3
mozilla/toolkit/locales/en-US/chrome/mozapps/plugins/plugins.properties
new revision: 1.6; previous revision: 1.5
mozilla/toolkit/locales/en-US/chrome/mozapps/preferences/update.dtd
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/installer/unix/install.it
new revision: 1.3; previous revision: 1.2
mozilla/toolkit/locales/en-US/installer/windows/charset.mk
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/README.txt
new revision: 1.2; previous revision: 1.1
mozilla/mail/locales/en-US/chrome/messenger/am-server-top.dtd
new revision: 1.5; previous revision: 1.4
mozilla/mail/locales/en-US/chrome/messenger/comm4xMailImportMsgs.properties
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/eudoraImportMsgs.properties
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/fieldMapImport.dtd
new revision: 1.6; previous revision: 1.5
mozilla/mail/locales/en-US/chrome/messenger/imapMsgs.properties
new revision: 1.7; previous revision: 1.6
mozilla/mail/locales/en-US/chrome/messenger/importMsgs.properties
new revision: 1.5; previous revision: 1.4
mozilla/mail/locales/en-US/chrome/messenger/localMsgs.properties
new revision: 1.7; previous revision: 1.6
mozilla/mail/locales/en-US/chrome/messenger/mailEditorOverlay.dtd
new revision: 1.3; previous revision: 1.2
mozilla/mail/locales/en-US/chrome/messenger/markByDate.dtd
new revision: 1.3; previous revision: 1.2
mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd
new revision: 1.20; previous revision: 1.19
mozilla/mail/locales/en-US/chrome/messenger/mime.properties
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/msgAccountCentral.dtd
new revision: 1.5; previous revision: 1.4
mozilla/mail/locales/en-US/chrome/messenger/msgHdrViewOverlay.dtd
new revision: 1.6; previous revision: 1.5
mozilla/mail/locales/en-US/chrome/messenger/oeImportMsgs.properties
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/outlookImportMsgs.properties
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/textImportMsgs.properties
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/threadpane.dtd
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/virtualFolderName.dtd
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
new revision: 1.8; previous revision: 1.7
mozilla/mail/locales/en-US/chrome/messenger/preferences/compose.dtd
new revision: 1.4; previous revision: 1.3
mozilla/mail/locales/en-US/chrome/messenger/preferences/display.dtd
new revision: 1.2; previous revision: 1.1
mozilla/mail/locales/en-US/chrome/messenger-smime/msgSecurityInfo.properties
new revision: 1.2; previous revision: 1.1
mozilla/mail/locales/en-US/chrome/mozapps/downloads/pref-downloads.dtd
new revision: 1.3; previous revision: 1.2
mozilla/mail/locales/en-US/os2/README.txt
new revision: 1.3; previous revision: 1.2
mozilla/security/manager/locales/en-US/chrome/pippki/certManager.dtd
new revision: 1.3; previous revision: 1.2
mozilla/security/manager/locales/en-US/chrome/pippki/pippki.properties
new revision: 1.5; previous revision: 1.4
mozilla/security/manager/locales/en-US/chrome/pippki/pref-ssl.dtd
new revision: 1.3; previous revision: 1.2
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: checkin needed [security]
Attachment #202916 - Attachment description: mail → mail [checked in]
Attachment #202917 - Attachment description: security → security [checked in]
Attachment #202918 - Attachment description: toolkit → toolkit [checked in]

Updated

12 years ago
Attachment #202915 - Flags: approval1.8.1?

Updated

12 years ago
Attachment #202915 - Flags: approval1.8.1? → branch-1.8.1+

Comment 10

12 years ago
Comment on attachment 202915 [details] [diff] [review]
browser (Help docs) [checked in]

Checking in mozilla/browser/locales/en-US/chrome/help/customization.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/customization.xhtml,v  <--  customization.xhtml
new revision: 1.19.2.2; previous revision: 1.19.2.1
done
Checking in mozilla/browser/locales/en-US/chrome/help/download_manager.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/download_manager.xhtml,v  <--  download_manager.xhtml
new revision: 1.17.4.4; previous revision: 1.17.4.3
done
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.