316558 - Stop supporting a few old nsIComponentManagerObsolete methods

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benjamin Smedberg]

There are a few old nsIComponentManagerObsolete methods that I would like to stop implementing, so that I can do this nsIComponentLoader->nsIModuleLoader thing more easily:

  unregisterComponent()
  unregisterComponentSpec()

These functions are not used anywhere in our code except a couple of obsolete tests.

Comment 1

[Benjamin Smedberg]

Attachment: Stop implementing obsolete methods, rev. 1

Comment 2

[Darin Fisher]

nsIComponentManagerObsolete is used with plugins, no?  are you sure that there aren't any plugins in use that need this?

Comment 3

[Benjamin Smedberg]

Pretty sure, yes... plugins do not typically register or unregister any components by location, if anything they register factories/services at runtime only.

Comment 4

[Darin Fisher]

Yeah, that would be my *guess* as well.  So, you want to just break it and see what happens then?

Comment 5

[Benjamin Smedberg]

Yes. It's likely that the moduleloader patch would change the way it works anyway, so I'm trying to reduce risk by splitting that up into small digestible and testable pieces.

Comment 6

[Darin Fisher]

Comment on attachment 203131 [details] [diff] [review]
Stop implementing obsolete methods, rev. 1

Well, always good to remove dead code ;-)  r=darin

*crossing fingers*

Comment 7

[Benjamin Smedberg]

Fixed on trunk.