Created attachment 203147 [details] [diff] [review] proposed patch First QueryInterfaceInner AddRefs innerPtr, then NS_NewXTFInterfaceAggregator AddRefs it, but only the nsXTFInterfaceAggregator object keeps the pointer to innerPtr. So innerPtr will be released only once (when nsXTFInterfaceAggregator is deleted). This means that we're leaking nsIXTFElement objects. So the patch adds one NS_RELEASE.
Created attachment 203299 [details] [diff] [review] proposed patch, better style
Created attachment 203438 [details] [diff] [review] using nsCOMPtr
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
I know that 1.8 is closed (unless we figure out a way to make this a security error ;-) ). How do we remember to push this to branch as soon as possible?
Comment on attachment 203438 [details] [diff] [review] using nsCOMPtr It would be really great to get this leak fix to branches. This has been on trunk over a year! and there are no known regressions.
Comment on attachment 203438 [details] [diff] [review] using nsCOMPtr approved for 188.8.131.52 and 184.108.40.206, a=dveditz for release-drivers
checked into 1.8 branch
checked into 1.8.0 branch
don't know how to test this. verified per checkins and no regressions on trunk
Status: RESOLVED → VERIFIED
Keywords: fixed220.127.116.11, fixed18.104.22.168 → verified22.214.171.124, verified126.96.36.199
You need to log in before you can comment on or make changes to this bug.