Closed Bug 316569 Opened 19 years ago Closed 19 years ago

Memory leak in XTF when using nsXTFInterfaceAggregator

Categories

(Core Graveyard :: XTF, defect)

Product:
Core Graveyard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

(Keywords: verified1.8.0.12, verified1.8.1.4)

Attachments

(1 file, 2 obsolete files)

using nsCOMPtr
2.93 KB, patch
bryner
: review+
bryner
: superreview+
dveditz
: approval1.8.1.4+
dveditz
: approval1.8.0.12+
Details | Diff | Splinter Review
Patch coming.
Attached patch proposed patch (obsolete) — — Splinter Review
First QueryInterfaceInner AddRefs innerPtr, then NS_NewXTFInterfaceAggregator AddRefs it, but only the nsXTFInterfaceAggregator object keeps the pointer to innerPtr. So innerPtr will be released only once (when nsXTFInterfaceAggregator is deleted). This means that we're leaking nsIXTFElement objects. So the patch adds one NS_RELEASE.
Attachment #203147 - Flags: superreview?(bryner)
Attachment #203147 - Flags: review?(bryner)
Attachment #203147 - Flags: superreview?(bryner)
Attachment #203147 - Flags: review?(bryner)
Attached patch proposed patch, better style (obsolete) — — Splinter Review
Attachment #203147 - Attachment is obsolete: true
Attachment #203299 - Flags: superreview?(bryner)
Attachment #203299 - Flags: review?(bryner)
Attached patch using nsCOMPtr — — Splinter Review
Attachment #203299 - Attachment is obsolete: true
Attachment #203438 - Flags: superreview?(bryner)
Attachment #203438 - Flags: review?(bryner)
Attachment #203299 - Flags: superreview?(bryner)
Attachment #203299 - Flags: review?(bryner)
Attachment #203438 - Flags: superreview?(bryner)
Attachment #203438 - Flags: superreview+
Attachment #203438 - Flags: review?(bryner)
Attachment #203438 - Flags: review+
Checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
I know that 1.8 is closed (unless we figure out a way to make this a security error ;-) ). How do we remember to push this to branch as soon as possible?
Comment on attachment 203438 [details] [diff] [review] using nsCOMPtr It would be really great to get this leak fix to branches. This has been on trunk over a year! and there are no known regressions.
Attachment #203438 - Flags: approval1.8.1.4?
Attachment #203438 - Flags: approval1.8.0.12?
Comment on attachment 203438 [details] [diff] [review] using nsCOMPtr approved for 1.8.0.12 and 1.8.1.4, a=dveditz for release-drivers
Attachment #203438 - Flags: approval1.8.1.4?
Attachment #203438 - Flags: approval1.8.1.4+
Attachment #203438 - Flags: approval1.8.0.12?
Attachment #203438 - Flags: approval1.8.0.12+
checked into 1.8 branch
Keywords: fixed1.8.1.4
checked into 1.8.0 branch
Keywords: fixed1.8.0.12
don't know how to test this. verified per checkins and no regressions on trunk
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.12, fixed1.8.1.4 → verified1.8.0.12, verified1.8.1.4
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: