Threadsafe assertions in nsFileChannel

VERIFIED FIXED

Status

()

Core
Networking
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: troy, Assigned: Gagan)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
I'm getting lots of asserts saying that the calling thread is not the same as 
the thread that created the object, and that the nsISuppports AddRef/Release 
functions are not thread safe (e.g., interlocked increment/decrement on Windows)

The problem seems to be the nsFileChannel class in nsFileChannel.cpp 
(netwerk/protocol/file/src).

This change fixes it so I no longer get all of the assertions:

Index: nsFileChannel.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/protocol/file/src/nsFileChannel.cpp,v
retrieving revision 1.81
diff -r1.81 nsFileChannel.cpp
95,100c95,100
< NS_IMPL_ISUPPORTS5(nsFileChannel,
<                    nsIFileChannel,
<                    nsIChannel,
<                    nsIRequest,
<                    nsIStreamListener,
<                    nsIStreamObserver)
---
> NS_IMPL_THREADSAFE_ISUPPORTS5(nsFileChannel,
>                               nsIFileChannel,
>                               nsIChannel,
>                               nsIRequest,
>                               nsIStreamListener,
>                               nsIStreamObserver)
(Assignee)

Comment 1

18 years ago
fixed. will be checked in when the tree opens...
Status: NEW → ASSIGNED
(Assignee)

Comment 2

18 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 3

18 years ago
marking verified per engineer's comments
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.