31657 - Threadsafe assertions in nsFileChannel

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[troy]

I'm getting lots of asserts saying that the calling thread is not the same as 
the thread that created the object, and that the nsISuppports AddRef/Release 
functions are not thread safe (e.g., interlocked increment/decrement on Windows)

The problem seems to be the nsFileChannel class in nsFileChannel.cpp 
(netwerk/protocol/file/src).

This change fixes it so I no longer get all of the assertions:

Index: nsFileChannel.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/protocol/file/src/nsFileChannel.cpp,v
retrieving revision 1.81
diff -r1.81 nsFileChannel.cpp
95,100c95,100
< NS_IMPL_ISUPPORTS5(nsFileChannel,
<                    nsIFileChannel,
<                    nsIChannel,
<                    nsIRequest,
<                    nsIStreamListener,
<                    nsIStreamObserver)
---
> NS_IMPL_THREADSAFE_ISUPPORTS5(nsFileChannel,
>                               nsIFileChannel,
>                               nsIChannel,
>                               nsIRequest,
>                               nsIStreamListener,
>                               nsIStreamObserver)

Comment 1

[Gagan]

fixed. will be checked in when the tree opens...

Comment 2

[Gagan]

fixed

Comment 3

[Tom Everingham]

marking verified per engineer's comments