Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Focusable elements in a page

RESOLVED FIXED in seamonkey1.0beta

Status

SeaMonkey
Help Documentation
--
minor
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Gérard Talbot, Assigned: Giacomo Magnini)

Tracking

({fixed1.8, polish})

unspecified
seamonkey1.0beta
x86
All
fixed1.8, polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

12 years ago
Steps to reproduce:
Go to:
1- Edit/Preferences.../Advanced category/Keyboard Navigation/Tab Key Navigation/
2- Help/Help Contents F1/Contents tab/Customizing Seamonkey/Navigator Settings/Advanced/Keyboard Navigation

Actual results: 

1a- 2nd checkbox gives:
"Buttons, radio buttons, checkboxes, and lists"
2a- it says:
"Buttons, radio buttons, check boxes, and lists: If
    checked, pressing Tab or Shift+Tab moves
    between buttons, radio buttons, check boxes, and lists."

Expected results: 2nd checkbox should give:
1b- "Buttons, radio buttons, checkboxes and selectable lists"
2b- it should say:
"Buttons, radio buttons, check boxes and selectable lists: If
    checked, pressing Tab or Shift+Tab moves
    between buttons, radio buttons, check boxes and selectable lists.
Note: text boxes are always part of the tabbing order. Page divisions with scrollbars are by default also in the tabbing order."

Explanations: 
- "lists" is ambiguous while selectable lists is more explicit
- <div>s with "overflow: auto;" or with "overflow: scroll;" are focusable. That's also true for Firefox 1.5 rv:1.8. See bug 316546 comment #4

Seamonkey 1.5a rv: 1.9a1 build 2005111409 under XP Pro SP2 here.

Comment 1

12 years ago
This should also be hidden for Mac. Only Find As You Type prefs is displayed in the Mac pref window...

Comment 2

12 years ago
Gérard, is there any bug on changing the wording in the pref panel?

Comment 3

12 years ago
Opened bug 316716 for the Mac-specific issue.
(Reporter)

Comment 4

12 years ago
> is there any bug on changing the wording in the pref panel?
I couldn't find any... but I could be wrong. Bug 114521 maybe? could have an incidence on bug 169045.
 

(Assignee)

Comment 5

12 years ago
Created attachment 205233 [details] [diff] [review]
As suggested.
Attachment #205233 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 6

12 years ago
Created attachment 205237 [details] [diff] [review]
This won't actually break the panel...
Attachment #205233 - Attachment is obsolete: true
Attachment #205237 - Flags: review?(iann_bugzilla)
Attachment #205233 - Flags: review?(iann_bugzilla)

Updated

12 years ago
Attachment #205237 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

12 years ago
Attachment #205237 - Flags: superreview?(neil.parkwaycc.co.uk)

Comment 7

12 years ago
Comment on attachment 205237 [details] [diff] [review]
This won't actually break the panel...

>+<!ENTITY tabNavigationForms.label "Buttons, radio buttons, checkboxes, and selectable lists">
I have a slight preference for selection lists (in all places obviously).

>+<!ENTITY tabNavigationTextboxes.label "Note: text boxes are always part of the tabbing order. Page divisions with scrollbars are by default also in the tabbing order.">
What do you mean by "by default", is there a preference for tabbing to scrollable regions (which I suggest as a better name for page divisions with scrollbars)?
(Assignee)

Comment 8

12 years ago
Created attachment 205653 [details] [diff] [review]
IS this better Neil?
Attachment #205237 - Attachment is obsolete: true
Attachment #205653 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #205653 - Flags: review+
Attachment #205237 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Updated

12 years ago
Attachment #205653 - Attachment is obsolete: true
Attachment #205653 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Comment 9

12 years ago
Created attachment 205654 [details] [diff] [review]
*shrug* sorry for bugspam
Attachment #205654 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #205654 - Flags: review+

Comment 10

12 years ago
Comment on attachment 205654 [details] [diff] [review]
*shrug* sorry for bugspam

>Index: extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml
>===================================================================
...
...
>-  <li class="noMac"><strong>Buttons, radio buttons, check boxes, and
>+  <li class="noMac"><strong>Buttons, radio buttons, check boxes, and selectable
>     lists</strong>:

Hmm... "selection lists", right? :P
(Assignee)

Comment 11

12 years ago
Created attachment 205659 [details] [diff] [review]
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)
Attachment #205654 - Attachment is obsolete: true
Attachment #205659 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #205659 - Flags: review+
Attachment #205654 - Flags: superreview?(neil.parkwaycc.co.uk)

Updated

12 years ago
Assignee: help.viewer → giacomo.magnini

Updated

12 years ago
Attachment #205659 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Updated

12 years ago
Component: Help Viewer → Help
Product: Documentation → Mozilla Application Suite
Target Milestone: --- → seamonkey1.0beta

Comment 12

12 years ago
Comment on attachment 205659 [details] [diff] [review]
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)

Low-risk Help/Pref wording polish...
Attachment #205659 - Flags: approval-seamonkey1.0?

Updated

12 years ago
Attachment #205659 - Flags: approval-seamonkey1.0? → approval-seamonkey1.0+

Comment 13

12 years ago
Checked in on trunk/branch by Mark.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

Comment 14

12 years ago
Comment on attachment 205659 [details] [diff] [review]
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch 1.8.0)
extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml;
new revision: 1.41.16.2; previous revision: 1.41.16.1
xpfe/components/prefwindow/resources/locale/en-US/pref-keynav.dtd;
new revision: 1.3.14.1; previous revision: 1.3
done
Attachment #205659 - Attachment description: Thanks Stefan for checking this. → Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)
You need to log in before you can comment on or make changes to this bug.