Last Comment Bug 316584 - Focusable elements in a page
: Focusable elements in a page
Status: RESOLVED FIXED
: fixed1.8, polish
Product: SeaMonkey
Classification: Client Software
Component: Help Documentation (show other bugs)
: unspecified
: x86 All
: -- minor (vote)
: seamonkey1.0beta
Assigned To: Giacomo Magnini
: Daniel Wang
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-15 13:02 PST by Gérard Talbot
Modified: 2005-12-22 16:17 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
As suggested. (3.60 KB, patch)
2005-12-07 10:22 PST, Giacomo Magnini
no flags Details | Diff | Review
This won't actually break the panel... (3.60 KB, patch)
2005-12-07 11:01 PST, Giacomo Magnini
iann_bugzilla: review+
Details | Diff | Review
IS this better Neil? (3.55 KB, patch)
2005-12-12 11:21 PST, Giacomo Magnini
prometeo.bugs: review+
Details | Diff | Review
*shrug* sorry for bugspam (3.55 KB, patch)
2005-12-12 11:28 PST, Giacomo Magnini
prometeo.bugs: review+
Details | Diff | Review
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0) (3.55 KB, patch)
2005-12-12 12:45 PST, Giacomo Magnini
prometeo.bugs: review+
neil: superreview+
kairo: approval‑seamonkey1.0+
Details | Diff | Review

Description Gérard Talbot 2005-11-15 13:02:12 PST
Steps to reproduce:
Go to:
1- Edit/Preferences.../Advanced category/Keyboard Navigation/Tab Key Navigation/
2- Help/Help Contents F1/Contents tab/Customizing Seamonkey/Navigator Settings/Advanced/Keyboard Navigation

Actual results: 

1a- 2nd checkbox gives:
"Buttons, radio buttons, checkboxes, and lists"
2a- it says:
"Buttons, radio buttons, check boxes, and lists: If
    checked, pressing Tab or Shift+Tab moves
    between buttons, radio buttons, check boxes, and lists."

Expected results: 2nd checkbox should give:
1b- "Buttons, radio buttons, checkboxes and selectable lists"
2b- it should say:
"Buttons, radio buttons, check boxes and selectable lists: If
    checked, pressing Tab or Shift+Tab moves
    between buttons, radio buttons, check boxes and selectable lists.
Note: text boxes are always part of the tabbing order. Page divisions with scrollbars are by default also in the tabbing order."

Explanations: 
- "lists" is ambiguous while selectable lists is more explicit
- <div>s with "overflow: auto;" or with "overflow: scroll;" are focusable. That's also true for Firefox 1.5 rv:1.8. See bug 316546 comment #4

Seamonkey 1.5a rv: 1.9a1 build 2005111409 under XP Pro SP2 here.
Comment 1 Stefan [:stefanh] 2005-11-15 13:38:45 PST
This should also be hidden for Mac. Only Find As You Type prefs is displayed in the Mac pref window...
Comment 2 Stefan [:stefanh] 2005-11-16 07:26:32 PST
Gérard, is there any bug on changing the wording in the pref panel?
Comment 3 Stefan [:stefanh] 2005-11-16 07:42:37 PST
Opened bug 316716 for the Mac-specific issue.
Comment 4 Gérard Talbot 2005-11-16 10:45:26 PST
> is there any bug on changing the wording in the pref panel?
I couldn't find any... but I could be wrong. Bug 114521 maybe? could have an incidence on bug 169045.
 

Comment 5 Giacomo Magnini 2005-12-07 10:22:15 PST
Created attachment 205233 [details] [diff] [review]
As suggested.
Comment 6 Giacomo Magnini 2005-12-07 11:01:07 PST
Created attachment 205237 [details] [diff] [review]
This won't actually break the panel...
Comment 7 neil@parkwaycc.co.uk 2005-12-10 13:47:25 PST
Comment on attachment 205237 [details] [diff] [review]
This won't actually break the panel...

>+<!ENTITY tabNavigationForms.label "Buttons, radio buttons, checkboxes, and selectable lists">
I have a slight preference for selection lists (in all places obviously).

>+<!ENTITY tabNavigationTextboxes.label "Note: text boxes are always part of the tabbing order. Page divisions with scrollbars are by default also in the tabbing order.">
What do you mean by "by default", is there a preference for tabbing to scrollable regions (which I suggest as a better name for page divisions with scrollbars)?
Comment 8 Giacomo Magnini 2005-12-12 11:21:10 PST
Created attachment 205653 [details] [diff] [review]
IS this better Neil?
Comment 9 Giacomo Magnini 2005-12-12 11:28:09 PST
Created attachment 205654 [details] [diff] [review]
*shrug* sorry for bugspam
Comment 10 Stefan [:stefanh] 2005-12-12 11:56:37 PST
Comment on attachment 205654 [details] [diff] [review]
*shrug* sorry for bugspam

>Index: extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml
>===================================================================
...
...
>-  <li class="noMac"><strong>Buttons, radio buttons, check boxes, and
>+  <li class="noMac"><strong>Buttons, radio buttons, check boxes, and selectable
>     lists</strong>:

Hmm... "selection lists", right? :P
Comment 11 Giacomo Magnini 2005-12-12 12:45:48 PST
Created attachment 205659 [details] [diff] [review]
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)
Comment 12 Stefan [:stefanh] 2005-12-12 21:59:47 PST
Comment on attachment 205659 [details] [diff] [review]
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)

Low-risk Help/Pref wording polish...
Comment 13 Stefan [:stefanh] 2005-12-13 11:31:48 PST
Checked in on trunk/branch by Mark.
Comment 14 Ian Neal 2005-12-22 16:17:53 PST
Comment on attachment 205659 [details] [diff] [review]
Thanks Stefan for checking this. (Checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch 1.8.0)
extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.xhtml;
new revision: 1.41.16.2; previous revision: 1.41.16.1
xpfe/components/prefwindow/resources/locale/en-US/pref-keynav.dtd;
new revision: 1.3.14.1; previous revision: 1.3
done

Note You need to log in before you can comment on or make changes to this bug.