Closed
Bug 316659
Opened 20 years ago
Closed 20 years ago
null dereference crash in markPageAsTyped
Categories
(Firefox :: Bookmarks & History, defect, P5)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha2
People
(Reporter: Gavin, Assigned: Gavin)
References
()
Details
(Keywords: crash, verified1.8.1)
Attachments
(1 file)
|
2.44 KB,
patch
|
asaf
:
review+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
This is a toolkit bug, but there's no Toolkit:History.
nsGlobalHistory::MarkPageAsTyped doesn't null check aURI, so passing null (from js, in this case) results in a crash.
|
Assignee | |
Comment 1•20 years ago
|
||
Clean up a few others as well.
Attachment #203213 -
Flags: review?(bugs.mano)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P5
|
||
Comment 2•20 years ago
|
||
Comment on attachment 203213 [details] [diff] [review]
patch
r=mano.
Attachment #203213 -
Flags: review?(bugs.mano) → review+
|
|
Assignee | |
Updated•20 years ago
|
Whiteboard: [checkin needed]
|
|
Assignee | |
Comment 3•20 years ago
|
||
mozilla/toolkit/components/history/src/nsGlobalHistory.cpp; new revision: 1.63;
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: null dereference in markPageAsTyped → null dereference crash in markPageAsTyped
Whiteboard: [checkin needed]
|
|
Assignee | |
Updated•20 years ago
|
Attachment #203213 -
Flags: approval1.8.1?
|
||
Updated•19 years ago
|
Severity: normal → critical
|
||
Comment 4•19 years ago
|
||
Comment on attachment 203213 [details] [diff] [review]
patch
This code will be going away with the new places impl.
Attachment #203213 -
Flags: approval1.8.1? → approval1.8.1-
|
|
Assignee | |
Updated•19 years ago
|
Attachment #203213 -
Flags: approval1.8.1- → approval-branch-1.8.1?(benjamin)
|
|
||
Updated•19 years ago
|
Attachment #203213 -
Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
|
|
Assignee | |
Comment 5•19 years ago
|
||
mozilla/toolkit/components/history/src/nsGlobalHistory.cpp 1.58.2.6
Keywords: crash,
fixed1.8.1
Version: Trunk → 2.0 Branch
|
|
Assignee | |
Updated•19 years ago
|
Target Milestone: Firefox 2 → Firefox 2 alpha2
|
|
Assignee | |
Comment 6•19 years ago
|
||
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2.
Keywords: fixed1.8.1 → verified1.8.1
Component: History → Bookmarks & History
QA Contact: history → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•