316748 - [RTL] [GTK] dropdown arrow is on the wrong side

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Tracy Walker [:tracy]]

seen on ar l10n build from 11/15

-go to Prefs | Content | Fonts and Colors

tested results:
notice the text for the two dropdown menus (font type and size) overlaps the down arrow for those menus.

expected results:  the text should not overlap the dropdown arrow

Comment 1

[Tracy Walker [:tracy]]

*** Bug 316749 has been marked as a duplicate of this bug. ***

Comment 2

[Tracy Walker [:tracy]]

this is happening in both arabic and hebrew which are right to left languages. it's not happening with left to right locales.

Comment 3

[Ayman Hourieh]

Reassigning to Prefs asignee, I don't think I'm responsible for this sort of things.

Comment 4

[Reuven Gonen]

see also Bug 297790. i think these two bugs are actually from the same origin.

Comment 5

[Asaf Romano (gone)]

Widget:GTK2 nsITheme issue.

Comment 6

[Behnam Esfahbod [:zwnj]]

*** Bug 347621 has been marked as a duplicate of this bug. ***

Comment 7

[Teune van Steeg]

Attachment: fix some GTK RTL issues

Comment 8

[Teune van Steeg]

Attachment: fix some GTK RTL issues

This patch will draw certain GTK Widgets RTL or LTR not depending on the text direction of the operating system, but only on Mozilla's current text direction.
This means that this patch makes it possible to draw RTL widgets for a RTL Firefox on a LTR OS.

This patch will fix the RTL display for the following widgets: dropdown menu (this bug), tabs (bug 402247) and checkbox/radio menu items (part of bug 297790). And it makes menu arrows display correctly for RTL locales on a LTR OS.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+                    rect->x - rect->width + 2 : rect->x + rect->width - 2;

I don't see how rect->x - rect->width makes sense. rect->x is always the left side of the rectangle, right?

+static void GetTextDirection(nsIFrame* aFrame, GtkTextDirection* aDirection)

Just return a GtkTextDirection parameter directly. Out parameters are evil unless you have to use them.

Comment 10

[Teune van Steeg]

Attachment: fix some GTK RTL issues v2

(In reply to comment #9)
> +                    rect->x - rect->width + 2 : rect->x + rect->width - 2;
> 
> I don't see how rect->x - rect->width makes sense. rect->x is always the left
> side of the rectangle, right?

It is the way the left border of the active tab is painted (bug 402247); The actual tab is already painted at this point, but the same tab (the tab before the selected tab) is used again to draw the 2px wide left border. 

For RTL tabs, the way I thought bug 402247 should be fixed, the right border of the active tab has to be painted. In that case we must shift the tab (its width -  2)px to the left to draw the 2px right border of the active tab. 

But there may be other ways to fix bug 402247, so I removed the fix I had in mind for the tabs from this patch and I will do that work in the appropriate bug.

Comment 11

[Reed Loden [:reed]]

I took the liberty of cleaning up some whitespace in gtkdrawing.c when I landed this.

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.51; previous revision: 1.50
done
Checking in widget/src/gtk2/gtkdrawing.h;
/cvsroot/mozilla/widget/src/gtk2/gtkdrawing.h,v  <--  gtkdrawing.h
new revision: 1.43; previous revision: 1.42
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.123; previous revision: 1.122
done

Comment 13

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).