Open Bug 316826 Opened 19 years ago Updated 1 month ago

references in "Activity log" should be displayed as clickable bug id's, url's, (users?)

Categories

(Bugzilla :: User Interface, enhancement)

enhancement
Not set
normal

Tracking

()

People

(Reporter: gangleri, Unassigned)

References

()

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

The "Activity log" would be improved if it would display clickable links for url's, bug id's.

User / user names - their e-mail address can be changed. If it is possible to preserve the righ names after a e-mail address / user name change it might be a good idea to provide the same clickable links on oser names as this is done inside the bug reports / comments.

regards reinhardt [[user:gangleri]]

Reproducible: Always

Steps to Reproduce:
see above
Actual Results:  
no clickable links are aveilable now in "Activity log"

Expected Results:  
clickable links should be aveilable in the future in "Activity log"
adding links for bug IDs is covered by bug 137751
Depends on: 137751
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: myk → ddkilzer
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.24
Attached patch Patch v1 (obsolete) — Splinter Review
This patch (ab)uses the quoteUrls filter to add links for URLs (including bug link titles and strikethrough text when appropriate!) in the 'bug_file_loc' field and email addresses for the 'assigned_to', 'cc' and 'qa_contact' fields.

I don't relish the thought of adding more mailto: links to Bugzilla due to email harvesting by spammers, but since these same addresses are already linked in bug comments, what difference does it really make?

Note that I did not try to pull names for email addresses because of the fact that if someone changes their email address, the change won't be reflected in the bugs_activity table.  In any case, it may be more useful to add this feature to Bugzilla::Template::quoteUrls() so the email-to-name replacement occurs in comments as well (if that's desired).
Attachment #215504 - Flags: review?
Comment on attachment 215504 [details] [diff] [review]
Patch v1

Looks good to me, other than this will bitrot when the blocker goes in.

Note that this won't linkify emails in the flag requests.
Attachment #215504 - Flags: review? → review+
Comment on attachment 215504 [details] [diff] [review]
Patch v1

Sorry, after I looked again this seems to remove @ obfuscation from the emails. Obfuscation is currently only done in html filter, maybe you need to teach it to quoteUrls too.. I don't think we can allow opening up email obfuscation at this point..

Who field and flag requestees could be linked too in the new patch.
Attachment #215504 - Flags: review+ → review-
Attached patch Patch v2Splinter Review
Changes since patch v1:

- Fixed Bugzilla::Template::quoteUrls() to obfuscate email addresses (see Bug 120030 for the original change which, incidentally, missed obfuscating email addresses in comments).
- Fixed bitrottedness from fix for Bug 137751.
- Added changes to table.html.tmpl to linkify the entire Who column and the Flag Request changes per Comment #5.  (I considered changing the default FILTER from 'html' to 'quoteUrls' to cover all bases but thought that might be a little heavy-handed.  I haven't done any performance testing to determine if there is a speed decrease on a bug with a large number of changes.)
Attachment #215504 - Attachment is obsolete: true
Attachment #222002 - Flags: review?
Attachment #222002 - Flags: review?(wicked+bz)
Attachment #222002 - Flags: review?(LpSolit)
Attachment #222002 - Flags: review?
(In reply to comment #6)
> - Fixed Bugzilla::Template::quoteUrls() to obfuscate email addresses (see Bug
> 120030 for the original change which, incidentally, missed obfuscating email
> addresses in comments).

In the long term, this should probably be extracted into a single subroutine.  I can see wanting to change the obfuscation methodology later, e.g., making the whole address entity-encoded.
Comment on attachment 222002 [details] [diff] [review]
Patch v2

>Index: template/en/default/bug/activity/table.html.tmpl
>+          [% operation.who FILTER quoteUrls %]

>+                [% ELSIF change.fieldname == 'bug_file_loc' ||
>+                         change.fieldname == 'assigned_to' ||
>+                         change.fieldname == 'cc' ||
>+                         change.fieldname == 'qa_contact' ||
>+                         change.fieldname == 'flagtypes.name' %]
>+                  [% change.removed FILTER quoteUrls %]

Per discussion with wicked and bkor on IRC, we estimated that calling quoteUrls to linkify email addresses was overkill. Moreover, quoteUrls is unable to linkify relative URLs given in the bug_file_loc field. We think we should have a new "FILTER email" which would be able to parse multiple email addresses separated by whitespaces and commas, so that you can use it for assigned_to, qa_contact and cc. bug_file_loc should probably be linkified separately; see how the URL link is built in show_bug.cgi.
Attachment #222002 - Flags: review?(wicked+bz)
Attachment #222002 - Flags: review?(LpSolit)
Attachment #222002 - Flags: review-
The trunk is now frozen -> TM: 3.2
Target Milestone: Bugzilla 3.0 → Bugzilla 3.2
Blocks: 376909
Not a bug, and 3.2 is now frozen.
Severity: minor → enhancement
Target Milestone: Bugzilla 3.2 → ---
Assignee: ddkilzer → ui
Status: ASSIGNED → NEW
No longer blocks: 376909
Attachment #9386819 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: