316908 - Add SVG to nsComputedDOMStyle

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Comment 1

[tor]

Attachment: SVG properties for nsComputedDOMStyle

Comment 2

[tor]

Attachment: update SVG nsComputedDOMStyle to tip, fix problems revealed by mochitests

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 273143 [details] [diff] [review]
update SVG nsComputedDOMStyle to tip, fix problems revealed by mochitests

> const PRInt32 nsCSSProps::kPointerEventsKTable[] = {
>+  eCSSKeyword_none, NS_STYLE_POINTER_EVENTS_NONE,

Instead of doing this, you should write nsComputedDOMStyle::GetPointerEvents like GetClear or GetBorderStyleFor.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

GetSVGPaintFor needs to do something about the fallback color -- it probably should create a space-separated value list.

I'm not sure if the stroke-dasharray stuff is ideal, but it'll do.

GetColorInterpolation and GetColorInterpolationFilters should use the |svg| variable rather than calling GetStyleSVG() again.

r+sr=dbaron with those changes.

Comment 5

[tor]

Attachment: update nsComputedDOMStyle::GetPointerEvents per comment

Comment 6

[tor]

Attachment: adjust nsComputedDOMStyle::GetSVGPaintFor

Not sure if this is exactly what you had in mind - currently appending the fallback for paint servers only.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It's the right place.  But I'd rather you created two values and made a value list out of them rather than duplicating the URI and Color code.  See, for example, GetCounterIncrement or GetBorderSpacing.

Comment 8

[tor]

Attachment: switch GetSVGPaintFor and GetStrokeDasharray to value lists

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 273174 [details] [diff] [review]
switch GetSVGPaintFor and GetStrokeDasharray to value lists

>+    if (!fallback) {
>+      delete valueList;
>+      return NS_ERROR_OUT_OF_MEMORY;
>+    }
>+
>+    if (!valueList->AppendCSSValue(fallback)) {
>+      delete valueList;
>+      delete fallback;
>+      return NS_ERROR_OUT_OF_MEMORY;
>+    }

Since delete is null-safe, you could combine these two into

if (!fallback || !valueList->AppendCSSValue(fallback)) {
  delete valueList;
  delete fallback;
  return NS_ERROR_OUT_OF_MEMORY;
}

r+sr=dbaron with that change

Comment 10

[tor]

Attachment: checkin version - includes dbaron's suggestion

Comment 11

[tor]

Checked in.