317102 - two untranslated strings in help for nb-no firefox

Status: VERIFIED FIXED

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

Description

[Håvard Mork]

two help content strings in firefox 1.5 are untranslated
toolkit\content\help\help-toc.rdf

discovered during qa

Low risk, looks sort-of stupid for users opening help. Should therefore be fixed.

Comment 1

[Håvard Mork]

Attachment: proposed patch to nb-no 1.5 branch

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 203629 [details] [diff] [review]
proposed patch to nb-no 1.5 branch

You might want to re-request approval for this for 1.5.1

Comment 3

[Håvard Mork]

Comment on attachment 203629 [details] [diff] [review]
proposed patch to nb-no 1.5 branch

Requesting approval for inclusion in 1.5.0.3. Fix is mainly of aesthetic character. The strings are very visible in the Help system, as they are the topmost help categories.

Low risk, relatively low importance.

Comment 4

[Axel Hecht [:Pike]]

This is an edge case, but as this change is in toolkit, if we take this change,
we would want a sign-off for both Firefox and Thunderbird 1.5.0.3.
Havard, is that ok for you?

Comment 5

[Håvard Mork]

Alex, thank you for the review. This is OK. 
If the change is accepted, we (nb-NO l10n team) will run the necessary tests. I assume proper information on when/where sign-off will take place will be provided later.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 203629 [details] [diff] [review]
proposed patch to nb-no 1.5 branch

Did you mean to ask for approval-l10n?

Comment 7

[Håvard Mork]

David, according to instructions by Axel Hecht, l10n related patches should be approval-1.8.0.3 and bugs blocking-1.8.0.3. Please see http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/7b4781397a3af6ab

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 203629 [details] [diff] [review]
proposed patch to nb-no 1.5 branch

Oops, never mind me.

Comment 9

[Jay Patel [:jay]]

Comment on attachment 203629 [details] [diff] [review]
proposed patch to nb-no 1.5 branch

a=jay per triage meeting

Comment 10

[Håvard Mork]

Checked in on l10n repository's MOZILLA_1_8_0_BRANCH

Checking in toolkit/chrome/mozapps/help/help-toc.rdf;
/l10n/l10n/nb-NO/toolkit/chrome/mozapps/help/help-toc.rdf,v  <--  help-toc.rdf
new revision: 1.2.2.1.2.1; previous revision: 1.2.2.1

Comment 11

[Axel Hecht [:Pike]]

Please test the fix in a nightly and add the fixed1.8.0.3 keyword if it is
indeed fixed on the current 1.8.0 nightlies.