317154 - Patch for bug 316732 caused refcount leak on balsa

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Adam Guthrie]

Tinderbox says the new leak is in nsLocalFile.

Comment 1

[Benjamin Smedberg]

It is extremely unlikely that bug 316732 caused this,  are there other options for the time the leak started? (Which leak increase is this about?)

Comment 2

[Andrew Schultz]

checkins: http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1132319280&maxdate=1132331639
build log: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1132331640.6338.gz

Comment 3

[Benjamin Smedberg]

OK, I see two jumps in the tracerefcnt logs:

first was on 11/16 between 10:50 and 15:10
   this jump is a "new" leak of three nsHostRecords, but was probably always present but we just started logging nsHostRecord recently, see bug 302724.

second was on 11/18 between 4:55 and 8:34
  in this jump, the number of nsLocalFiles leaked (4) did not change, but nsLocalFile increased in size by one word (for the nsIHashable vtable pointer)... this is not something that needs to be fixed. These nsLocalFile leaks are "expected" because the toolkit nsAppRunner.cpp code holds onto localfiles after XPCOM shutdown (which is allowed), and so they appear leaked when they actually are not.

Comment 4

[Benjamin Smedberg]

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-11-16+10%3A50&maxdate=2005-11-16+15%3A10&cvsroot=%2Fcvsroot is the checkin log, FWIW