The default bug view has changed. See this FAQ.

Change "Check Now" to "Set Firefox as the default browser"

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Preferences
--
enhancement
RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: Peter Crocker, Assigned: Christian Ascheberg)

Tracking

Trunk
Firefox 15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

Change:
Firefox / Tools / Options / General / Default Browser / [Check Now]

To:
Firefox / Tools / Options / General / Default Browser / [Set Firefox as the default browser]

Then delete the confirmation dialogs since they will be unnecessary.



Reproducible: Always
Severity: trivial → enhancement

Comment 1

10 years ago
don't agree, I found myself really want to check the current firefox is default browser or not, especially I have multiple version of firefox exist in my system

Another suggestion is directly show "Firefox is not your default browser" and change the button [Set Firefox as the default browser]

Comment 2

9 years ago
IE7 has an elegant solution. A single make default button is either active if it is not the default browser or grayed out if it is. It conveys all the information without the dialog box or extra steps and is something I would like to see in Firefox.
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
I think the solution in Comment #2 sounds like it could be feasible.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 606258
(Assignee)

Comment 5

5 years ago
Created attachment 619449 [details] [diff] [review]
patch v1

possible patch
Assignee: nobody → c.ascheberg
Attachment #619449 - Flags: feedback?(robert.bugzilla)
(Assignee)

Comment 6

5 years ago
(In reply to Christian Ascheberg from comment #5)
> Created attachment 619449 [details] [diff] [review]

It may be nicer to add an additional description with proper label to be shown just after setting the browser as default browser.
Also, I don't know how to really check whether the action was successful (in some cases it needs to be confirmed through Windows UAC, which does not happen immediately).
Comment on attachment 619449 [details] [diff] [review]
patch v1

I am on record in other bugs being adamantly against having extremely long button text so I am going to bow out on this bug except to feedback- the patch and to note that not only will the long text be a problem at the very least for localization but changing the text will likely also likely cause problems with localization. I suggest that you get someone on the UX team involved in deciding what to do here.
Attachment #619449 - Flags: feedback?(robert.bugzilla) → feedback-
(Assignee)

Comment 8

5 years ago
(In reply to Robert Strong [:rstrong] (do not email) from comment #7)

It's right that the button text is too long.

Justin Dolske said in https://bugzilla.mozilla.org/show_bug.cgi?id=588297#c5 :
> Quick example:
>
> [X] Check to see if Firefox is default browser on startup.
>     Firefox is currently your default browser.
> 
> [X] Check to see if Firefox is default browser on startup.
>     Firefox is not your default browser. [Make default]
Justin's suggestions in comment 8 are close, but I think we can do even better and reduce the happytalk a bit:

When Firefox is already the default browser:

 [X] Check to see if Firefox is default browser on startup.
 Firefox is currently your default browser.

When it's not:

 [X] Check to see if Firefox is default browser on startup.
 [Make Firefox the default browser]

This is more than a couple of words, but better than having the redundant sentence.
(Assignee)

Comment 10

5 years ago
Created attachment 619856 [details]
screenshot

same patch, but with text from comment #9
Attachment #619856 - Flags: ui-review?(limi)
Comment on attachment 619856 [details]
screenshot

Looks fine to me — the alignment is a bit off, but I assume this is because you need space for the button even when it's not there. 

In any case, this is a much better interaction flow.
Attachment #619856 - Flags: ui-review?(limi) → ui-review+
(Assignee)

Comment 12

5 years ago
Created attachment 622996 [details] [diff] [review]
patch v2

patch according to screenshot
also updates in-content preferences
Attachment #619449 - Attachment is obsolete: true
Attachment #622996 - Flags: review?(gavin.sharp)
Attachment #622996 - Flags: review?(gavin.sharp) → review?(jaws)
Comment on attachment 622996 [details] [diff] [review]
patch v2

Review of attachment 622996 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for also updating the in-content preferences :)
Attachment #622996 - Flags: review?(jaws) → review+
Whiteboard: [autoland-try:-b do -p linux -u mochitests -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p linux -u mochitests -t none] → [autoland-in-queue]

Comment 14

5 years ago
Autoland Patchset:
	Patches: 622996
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=13d701c8de0e
Try run started, revision 13d701c8de0e. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=13d701c8de0e
Whiteboard: [autoland-in-queue]
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b043e963658
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/7b043e963658
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 763232
You need to log in before you can comment on or make changes to this bug.