317327 - Eliminate method |nsImapServerResponseParser::end_of_line()|

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hans-Andreas Engel]

The method |nsImapServerResponseParser::end_of_line()| should be inlined and eliminated, because this makes the code in |nsImapServerResponseParser.cpp| easier to understand.

Comment 1

[Hans-Andreas Engel]

Note that the method |response_data()| is invoked only once.  I suggest to no longer call |end_of_line()| from that method; but rather to call it directly from |nsImapServerResponseParser::ParseIMAPServerResponse|

Comment 2

[Hans-Andreas Engel]

Attachment: Eliminate |nsImapServerResponseParser::end_of_line()|

Comment 3

[David :Bienvenu]

Comment on attachment 203828 [details] [diff] [review]
Eliminate |nsImapServerResponseParser::end_of_line()|

I'll give this a try. Thx for the patch!

Comment 4

[David :Bienvenu]

this caused syntax errors at shutdown parsing the "BYE" response...

Comment 5

[Hans-Andreas Engel]

Attachment: Eliminate |nsImapServerResponseParser::end_of_line()|, v2

David, thank you for the hint.  A check for |ContinueParse()| was missing in the  previous patch!  This is now fixed.

Additionally, I added another such check which is needed further below.  Also, in |nsImapServerResponseParser::resp_cond_bye()|, the call to |skip_to_CRLF()| can be eliminated (it did not do anything because the parser was already disconnected).

Comment 6

[David :Bienvenu]

Comment on attachment 204829 [details] [diff] [review]
Eliminate |nsImapServerResponseParser::end_of_line()|, v2

fix checked in, thx Hans-Andreas.